[coordinator] Make <500 endpoint errors as invalid params error #3783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
map <500 response codes to 400.
Special notes for your reviewer:
Makes sure 4xx errors are wrapped in InvalidParamsError that eventually gets mapped to 400 HTTP status code.
This is important because prometheus scraper retries 5xx errors. Before this change any errors returned from endpoint would have been mapped to 500.
Storage layer abstracts away HTTP so it's not possible to just respond with same status codes as in response from the endpoint. However it seems enough to map to 400 or 500 based on Prometheus scraper implementation.
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: