Skip to content

Commit

Permalink
Merge pull request #6 from kitagry/quick-fix
Browse files Browse the repository at this point in the history
fix some bugs
  • Loading branch information
kitagry authored May 6, 2023
2 parents 3bf7f96 + 5c6b0ea commit 67eba49
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bqemulatormanager/emulator.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(self, project_name: str, port: int, launch_emulator: bool = True, d
if is_port_in_use(port):
raise PortOccupiedError(f"port {port} is occupied.")
self.running_flg = True
self.proc = subprocess.Popen(["bigquery-emulator", "--project", f"{project_name}", "--port", f"{port}" "--log-level", f"{log_level}"], shell=True)
self.proc = subprocess.Popen(["bigquery-emulator", "--project", f"{project_name}", "--port", f"{port}", "--log-level", f"{log_level}"], shell=True)

def __del__(self):
if self.running_flg:
Expand Down
2 changes: 1 addition & 1 deletion bqemulatormanager/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def load(self, data, path):

def create_dataset(self, dataset_name: str, exists_ok=True):
dataset = bigquery.Dataset(f"{self.project_name}.{dataset_name}")
self.client.create_dataset(dataset)
self.client.create_dataset(dataset, exists_ok=exists_ok)
self.structure[dataset_name] = {}

def create_table(self, dataset_name: str, table_name: str, schema: List[bigquery.SchemaField]):
Expand Down
17 changes: 16 additions & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,16 @@ isort = "*"
black = "*"
mypy = "*"
pandas-stubs = "*"
flake8-unused-arguments = "^0.0.13"

[tool.flake8]
per-file-ignores = """
__init__.py: F401
"""
max-line-length = 160
exclude = "venv/*,tox/*"
# ignore methods like __enter__, __exit__
unused-arguments-ignore-dunder = true

[tool.black]
target-version = ['py38', 'py39', 'py310', 'py311']
Expand Down

0 comments on commit 67eba49

Please sign in to comment.