Skip to content

Commit

Permalink
Fix the plugin version for the export plugins
Browse files Browse the repository at this point in the history
  • Loading branch information
m4gr3d committed Jan 18, 2024
1 parent b82ca71 commit 3bf3679
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 14 deletions.
2 changes: 1 addition & 1 deletion common/src/main/cpp/export/export_plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

using namespace godot;

OpenXREditorExportPlugin::OpenXREditorExportPlugin() {}
OpenXREditorExportPlugin::OpenXREditorExportPlugin() : _plugin_version(PLUGIN_VERSION) {}

void OpenXREditorExportPlugin::_bind_methods() {}

Expand Down
8 changes: 3 additions & 5 deletions common/src/main/cpp/export/export_plugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@

using namespace godot;

static const char *PLUGIN_VERSION = "2.0.2-stable";

// Set of supported vendors
static const char *META_VENDOR_NAME = "meta";
static const char *PICO_VENDOR_NAME = "pico";
Expand Down Expand Up @@ -81,10 +83,6 @@ class OpenXREditorExportPlugin: public EditorExportPlugin {
_vendor = vendor_name;
}

void set_plugin_version(const String &plugin_version) {
_plugin_version = plugin_version;
}

protected:
static void _bind_methods();

Expand Down Expand Up @@ -137,5 +135,5 @@ class OpenXREditorExportPlugin: public EditorExportPlugin {


String _vendor;
String _plugin_version;
const String _plugin_version;
};
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ void KhronosEditorPlugin::_bind_methods() {}
void KhronosEditorPlugin::_enter_tree() {
// Initialize the editor export plugin
khronos_export_plugin = memnew(KhronosEditorExportPlugin);
khronos_export_plugin->set_plugin_version(get_plugin_version());

add_export_plugin(khronos_export_plugin);
}

Expand Down
2 changes: 0 additions & 2 deletions godotopenxrlynx/src/main/cpp/export/lynx_export_plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ void LynxEditorPlugin::_enter_tree() {
// Initialize the editor export plugin
lynx_export_plugin = memnew(OpenXREditorExportPlugin);
lynx_export_plugin->set_vendor_name(LYNX_VENDOR_NAME);
lynx_export_plugin->set_plugin_version(get_plugin_version());

add_export_plugin(lynx_export_plugin);
}

Expand Down
2 changes: 0 additions & 2 deletions godotopenxrmeta/src/main/cpp/export/meta_export_plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ void MetaEditorPlugin::_bind_methods() {}
void MetaEditorPlugin::_enter_tree() {
// Initialize the editor export plugin
meta_export_plugin = memnew(MetaEditorExportPlugin);
meta_export_plugin->set_plugin_version(get_plugin_version());

add_export_plugin(meta_export_plugin);
}

Expand Down
2 changes: 0 additions & 2 deletions godotopenxrpico/src/main/cpp/export/pico_export_plugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ void PicoEditorPlugin::_enter_tree() {
// Initialize the editor export plugin
pico_export_plugin = memnew(OpenXREditorExportPlugin);
pico_export_plugin->set_vendor_name(PICO_VENDOR_NAME);
pico_export_plugin->set_plugin_version(get_plugin_version());

add_export_plugin(pico_export_plugin);
}

Expand Down

0 comments on commit 3bf3679

Please sign in to comment.