Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Only display a notification once #24 #25

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Feat: Only display a notification once #24 #25

merged 2 commits into from
Jul 27, 2023

Conversation

agoodshort
Copy link
Contributor

This PR implements logic to avoid displaying multiple times the same notification message (mostly affecting nvim-notify users).

Behaviour:
A notification message is repeated only if max_time is reached

Fixes #24

@m4xshen
Copy link
Owner

m4xshen commented Jul 27, 2023

Hmm, now the notification of disable key doesn't show anymore.

agoodshort
agoodshort commented Jul 27, 2023
View reviewed changes
lua/hardtime/init.lua Outdated Show resolved Hide resolved
@agoodshort
Copy link
Contributor Author

Now it should be okay

@m4xshen m4xshen merged commit 96ae09b into m4xshen:main Jul 27, 2023
@m4xshen
Copy link
Owner

m4xshen commented Jul 27, 2023

Thanks for the PR ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4xshen m4xshen m4xshen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only display a notification once
2 participants
@agoodshort @m4xshen