chore: add generic typing to table component #259
Conversation
|
|
||
| export type { ColumnType, ExpandableConfig, ColumnsType, TableProps } | ||
|
|
||
| export const Table = (props: ITableProps) => { | ||
| export const Table = <RecordType extends AnyObject = any>(props: ITableProps<RecordType>) => { |
There was a problem hiding this comment.
Oh boy AnyObject that has any as a default. That's too many any's 😄
Jokes aside, can we do the same as Antd and use AnyObject = AnyObject?
There was a problem hiding this comment.
sure thing, i got this from node_modules/antd/es/table/InternalTable.d.ts:10 but your link seems legit
| @@ -1,17 +1,18 @@ | |||
| import { Table as AntTable } from 'antd' | |||
| import { type TableProps as AntTableProps } from 'antd' | |||
| import { type AnyObject } from 'antd/lib/_util/type' | |||
There was a problem hiding this comment.
Does it matter if we mix imports from antd/es and antd/lib? I know this is only a type, I'm wondering how this transpiles, though. I was reading about type imports the other day and I think this transpiles to:
import { } from 'antd/lib/_util/type
This is minor, just asking if you knew how it all works, I don't really.
There was a problem hiding this comment.
i also dont really 😩 but we seem to mostly use /es
ive changed this and the one other /lib import to be consistent with the rest of the project
|
🎉 This PR is included in version 1.17.0-ups-configurable-cookie.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.16.2-query-select-number.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Instructions
mainSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)