refactor: Migrate Internal ProviderPersistence class to kotlin #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
requested changes
Jan 6, 2025
| private fun applyMacro(defaultString: String): String { | ||
| var defaultString = defaultString | ||
| if (!isEmpty(defaultString) && defaultString.startsWith("%")) { | ||
| defaultString = defaultString.lowercase(Locale.getDefault()) |
There was a problem hiding this comment.
Are we sure we want to use the default locale here? I'm not saying we don't, but is this different in any way from the toLowerCase() function in Java? Does getDefault() get the current system default or some universal default? I've been bitten by locale bugs in the past, so I want to make sure we're 100% certain here.
There was a problem hiding this comment.
so here Locale.getDefault() will return the default language for system. languages where case rules vary (e.g., Turkish).
|
|
||
| private fun generateAID(): String { | ||
| var uuid = UUID.randomUUID().toString().replace("-", "") | ||
| uuid = uuid.uppercase(Locale.getDefault()) |
There was a problem hiding this comment.
Same concern about locale here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)