Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Disable location tracking to stop setting location updates #540

Merged
merged 4 commits into from
Feb 6, 2025
Merged

fix: Disable location tracking to stop setting location updates #540

merged 4 commits into from
Feb 6, 2025

Conversation

Mansi-mParticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Fix issue where previous location details were still being sent after calling disableLocationTracking(). Now, setLocation is set to null to clear the previous location.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle force-pushed the fix/SQDSDKS-7031-disableLocationTracking branch from df44010 to 341e8a5 Compare February 4, 2025 16:26
rmi22186
rmi22186 reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test to this PR that shows the behavior after this change?

@Mansi-mParticle Mansi-mParticle merged commit 8f68edb into development Feb 6, 2025
23 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-7031-disableLocationTracking branch February 6, 2025 04:04
mparticle-automation added a commit that referenced this pull request Feb 7, 2025
@mparticle-automation
chore: 5.58.7 (release)
93de3b8 
## [5.58.7](v5.58.6...v5.58.7) (2025-02-07)

### Bug Fixes

* Disable location tracking to stop setting location updates ([#540](#540)) ([8f68edb](8f68edb))

### Updates & Maintenance

* Update submodules ([a9ca8d9](a9ca8d9))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.58.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mansi-mParticle @mparticle-automation @rmi22186