Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve mParticle reset methods #263

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

This looks big because of all the test cleanup, but the only real changes are in the mParticle.m/h files and are minimal

  • Revert old reset method to it's original implementation and mark it deprecated
  • Update new reset: method to use async dispatch to prevent potential for deadlocks
  • Clean up tests and ensure use of new reset method

Testing Plan

  • Was this tested locally? If not, explain why.
  • All tests pass and performed E2E test to confirm workspace switching still works as expected

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit cde71a2 into development Mar 14, 2024
11 checks passed
@einsteinx2 einsteinx2 deleted the feat/6229-improve-mparticle-reset-methods branch March 14, 2024 17:58
mparticle-automation added a commit that referenced this pull request Mar 19, 2024
# [8.21.0](v8.20.0...v8.21.0) (2024-03-19)

### Bug Fixes

* Correct threading around user notification log ([#261](#261)) ([456160b](456160b))
* Refactor MPUploadBuilder to attempt to eliminate rare crash in withLocation: method ([#262](#262)) ([60cd0c8](60cd0c8))

### Features

* Improve mParticle reset methods ([#263](#263)) ([cde71a2](cde71a2))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants