feat: Refactor usage of XHR for Config API #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
force-pushed
the
feat/SQDSDKS-6566-refactor-xhr-config-api
branch
from
87cc92a
to
aaf62fe
Compare
rmi22186
reviewed
Aug 20, 2024
Co-authored-by: Robert Ing <rmi22186@gmail.com>
rmi22186
requested changes
Aug 21, 2024
Comment on lines
+171
to
+174
| mpInstance?.Logger?.verbose( | ||
| 'Issue with receiving configuration from server, received HTTP Code of ' + | ||
| response.statusText | ||
| ); |
There was a problem hiding this comment.
i don't think this is ever reached? I think this can be removed.
There was a problem hiding this comment.
If the response.status is anything other than 200, this will be reached.
Co-authored-by: Robert Ing <rmi22186@gmail.com>
|
rmi22186
approved these changes
Aug 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [2.28.0](v2.27.0...v2.28.0) (2024-08-26) ### Features * Refactor usage of XHR for Config API ([#898](#898)) ([0b6fae6](0b6fae6))
|
🎉 This PR is included in version 2.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)