refactor: Use fetch instead of XHR for forwarding stats uploads #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
requested changes
Aug 23, 2024
src/apiClient.ts
Outdated
| mid: number; | ||
| esid: number; | ||
| n: string; | ||
| attrs: Dictionary<any>; |
There was a problem hiding this comment.
Let's avoid using any. Either we should make a type for this attribute, or use Record<string, string> if it's a simple key/value pair. I would prefer the former if there are a specific attributes that must be passed.
src/apiClient.ts
Outdated
Comment on lines
183
to
185
| this.sendSingleForwardingStatsToServer = async ( | ||
| forwardingStatsData: IForwardingStatsData | ||
| ) => { |
There was a problem hiding this comment.
Suggested change
| this.sendSingleForwardingStatsToServer = async ( | |
| forwardingStatsData: IForwardingStatsData | |
| ) => { | |
| this.sendSingleForwardingStatsToServer = async ( | |
| forwardingStatsData: IForwardingStatsData | |
| ): void => { |
There was a problem hiding this comment.
i ended up moving this to the forwarder.js file, so we lost the typing here. it seemed to fit better there logically, but i can revert if you think keeping the types is more important than organization
alexs-mparticle
requested changes
Aug 23, 2024
rmi22186
commented
Aug 23, 2024
Co-authored-by: Alex S <49695018+alexs-mparticle@users.noreply.github.com>
|
alexs-mparticle
approved these changes
Aug 27, 2024
alexs-mparticle
added
wait to merge
refactor
rmi22186
added a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
This PR prioritizes using
fetchin when sending forwarding stats to mParticle servers. XHR is used as a fallback.Testing Plan
window.fetchin order to test XHR fallback.Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)