Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate CookieSyncManager to TypeScript #944

Merged
merged 23 commits into from
Nov 12, 2024
Merged

refactor: Migrate CookieSyncManager to TypeScript #944

merged 23 commits into from
Nov 12, 2024

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Oct 31, 2024 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Migrate CookieSyncManager to TypeScript and add Jest Unit Tests

Testing Plan

  • Was this tested locally? If not, explain why.
  • Run automated tests and verify that they continue to pass

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle force-pushed the test/SQDSDKS-5084-cookie-sync-tests branch from 8e661d6 to 50cd525 Compare October 31, 2024 17:50
@alexs-mparticle alexs-mparticle marked this pull request as ready for review October 31, 2024 18:09
@alexs-mparticle alexs-mparticle added the refactor Changes to the structure of the code label Nov 7, 2024
@alexs-mparticle alexs-mparticle changed the base branch from refactor/SQDSDKS-4800-cookie-sync-interfaces to development November 7, 2024 16:25
@alexs-mparticle alexs-mparticle force-pushed the test/SQDSDKS-5084-cookie-sync-tests branch from 50cd525 to e139d03 Compare November 7, 2024 16:30
rmi22186
rmi22186 requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the jest tests are awesome. THANK YOU. minor nits mostly i'd say, and some commentary.

src/consent.ts Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
test/src/tests-cookie-syncing.ts Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Outdated Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Outdated Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Show resolved Hide resolved
rmi22186
rmi22186 requested changes Nov 7, 2024
View reviewed changes
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Outdated Show resolved Hide resolved
test/jest/cookieSyncManager.spec.ts Outdated Show resolved Hide resolved
@alexs-mparticle @rmi22186
Apply suggestions from code review
15f082e 
Co-authored-by: Robert Ing <rmi22186@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@alexs-mparticle alexs-mparticle merged commit b6883b6 into development Nov 12, 2024
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
refactor Changes to the structure of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexs-mparticle @rmi22186