Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Install webpack automatically #116

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Install webpack automatically #116

merged 2 commits into from
Jul 15, 2021

Conversation

FernandoGarcia
Copy link
Contributor

Hi!

I think it's the best way to install the packages automatically.

The build process will take about 2 minutes more at first run then just npm run build command will be called every time.

I'm leaving debug messages in case do you want try but I can remove it later if needed.

Best regards.

Copy link
Owner

@maakbaas maakbaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal! In general I agree, but see the comments in the review.

scripts/preBuildHTML.py Outdated Show resolved Hide resolved
scripts/preBuildHTML.py Outdated Show resolved Hide resolved
scripts/preBuildHTML.py Outdated Show resolved Hide resolved
@maakbaas maakbaas merged commit 06e1614 into maakbaas:master Jul 15, 2021
@maakbaas
Copy link
Owner

Great! Thanks :).

@FernandoGarcia FernandoGarcia deleted the Install-webpack branch July 15, 2021 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants