Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Add timeout parameter for customising wifi connection timeout #99

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

jarrodbell
Copy link
Contributor

No description provided.

@maakbaas
Copy link
Owner

maakbaas commented Apr 7, 2021

Thanks for the proposal. Before accepting, two small requests:

  • Could you add an overloaded function without the timeout to keep backwards compatibility?
  • Can you update the docs in docs/wifi-manager.md accordingly?

@jarrodbell
Copy link
Contributor Author

jarrodbell commented Apr 7, 2021

Doesn't the default param value suffice? It already defaults to the same default as the WiFi package.

@maakbaas
Copy link
Owner

Doesn't the default param value suffice? It already defaults to the same default as the WiFi package.

Yes you are right, sorry I overlooked that :). Thanks!

@maakbaas maakbaas merged commit 903c27b into maakbaas:master Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants