Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had a typescript issue using this matcher with named interface types like
The error is (with typescript v4.4.3):
If the type information is removed, everything works OK. So when I checked, I've seen there are more runtime type checks (in
recursiveCheck
) so maybe the typing could be relaxed a bit to allow this scenario. Unfortunately I couldn't come up with a better solution than just allowing the exact type coming fromexpect(value: T)
... which I think if the user would use, it should be most of the time correct.I hope this solution is acceptable (or somebody could improve it). Thanks.