This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Fix for days_between_notifications
#32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the only times `last_seen` is updated are when it's blank or to make it blank if no updates are needed. In order not to notify if there is `days_between_notifications` set, `last_seen` has to be updated when the actual notification happens.
Otherwise, you're comparing something like `10.15` to `10`. In order to compare `10.15` to `10.15`, the right side of the comparison has to be `os_version` instead of `os_version_major`.
|
As I'm doing further testing, I'm not sure that second commit makes sense. I swear I have a 10.15 machine on which it spits back Disregard this PR for now. I clearly need to do even more testing... |
|
Heh. Welcome to my life. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes it so that if
days_between_notificationsis set, it's also respected.Two pieces to this are:
os_versioninstead ofos_version_major)last_seenpref every time the notification window actually appears