Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the scooter protocol documentation provided by CamiAlfa, found in the documentation folder, the battery current is specified in Amps and should be divided by 100.
m365/doc/protocol.md
Line 240 in cc61bfd
However, you are dividing it by 10 in your code.
m365/src/session/battery.rs
Line 40 in cc61bfd
m365/src/session/battery.rs
Line 87 in cc61bfd
This causes your test to fail, as it expects 0.01 but receives 0.1.
m365/tests/motor_info_test.rs
Line 33 in cc61bfd
Apart from that, I want to congratulate you on the excellent work you did implementing the protocol in Rust. It is very useful.