test: basic fuzzing #407
Merged
test: basic fuzzing #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @LeoDog896! I did some experiences with fuzzing Logos in the past, with no specific conclusion, so I didn't push any configuration to the main branch. If we push a fuzzing configuration, we at least need some good motivation to keep it: the best would be to show that it helped to find an issue. Moreover, it would also be great to include some words about it in the book (or README) to help contributors understand how fuzzing works and why they should run it. Otherwise, this is just going to be some pieces of code that will never be used :-/ |
|
The fuzzing can indeed find issues that can help improve developer experience - it's not something that needs to be constantly run as the function currently being fuzzed isn't a function susceptible to user input (and I'm unsure of a strategy to fuzz the logos generation without it being painfully slow) but lots of people, from the issues, have trouble diagnosing the confusing error messages. For example, |
jeertmans
requested changes
Aug 7, 2024
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
|
|
|
Thanks @LeoDog896! |
jeertmans
approved these changes
Aug 9, 2024
akrantz01
referenced
this pull request
in akrantz01/antsi
Sep 19, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [logos](https://logos.maciej.codes/) ([source](https://github.com/maciejhirsz/logos)) | dependencies | patch | `0.14.1` -> `0.14.2` | --- ### Release Notes <details> <summary>maciejhirsz/logos (logos)</summary> ### [`v0.14.2`](https://github.com/maciejhirsz/logos/releases/tag/v0.14.2): - Optional `forbid_unsafe` feature, fuzzing, book, and more! [Compare Source](https://github.com/maciejhirsz/logos/compare/v0.14.1...v0.14.2) #### What's Changed - chore(book): added link to Rust's reference by [@​CommanderStorm](https://github.com/CommanderStorm) in [https://github.com/maciejhirsz/logos/pull/411](https://github.com/maciejhirsz/logos/pull/411) - feat: impl Source for T: Deref in no_std by [@​yjhmelody](https://github.com/yjhmelody) in [https://github.com/maciejhirsz/logos/pull/406](https://github.com/maciejhirsz/logos/pull/406) - fix(codegen/regex): allow vec growth on parse by [@​LeoDog896](https://github.com/LeoDog896) in [https://github.com/maciejhirsz/logos/pull/405](https://github.com/maciejhirsz/logos/pull/405) - test: basic fuzzing by [@​LeoDog896](https://github.com/LeoDog896) in [https://github.com/maciejhirsz/logos/pull/407](https://github.com/maciejhirsz/logos/pull/407) - feat(lib): add `forbid_unsafe` feature to disable unsafe code by [@​davidkern](https://github.com/davidkern) in [https://github.com/maciejhirsz/logos/pull/413](https://github.com/maciejhirsz/logos/pull/413) - chore(version): release v0.14.2 by [@​jeertmans](https://github.com/jeertmans) in [https://github.com/maciejhirsz/logos/pull/422](https://github.com/maciejhirsz/logos/pull/422) #### New Contributors - [@​CommanderStorm](https://github.com/CommanderStorm) made their first contribution in [https://github.com/maciejhirsz/logos/pull/411](https://github.com/maciejhirsz/logos/pull/411) - [@​yjhmelody](https://github.com/yjhmelody) made their first contribution in [https://github.com/maciejhirsz/logos/pull/406](https://github.com/maciejhirsz/logos/pull/406) - [@​davidkern](https://github.com/davidkern) made their first contribution in [https://github.com/maciejhirsz/logos/pull/413](https://github.com/maciejhirsz/logos/pull/413) **Full Changelog**: maciejhirsz/logos@v0.14.1...v0.14.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/akrantz01/antsi). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cryptic error messages are thrown on derive when parsing regex, and without backtraces, confusion about these errors appears like #389. This adds fuzzing with AFL, which immediately caught issue #389, amongst a few others I have yet to diagnose.