-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add precision@k and recall@k #58
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
366ecaf
add precision and recall
graytowne 47b48b5
add precision and recall
graytowne 3c44b2d
clean code
graytowne 75bf9d5
fix print for python3
graytowne 1d290ac
Merge branch 'master' of github.com:maciejkula/spotlight
graytowne d022c05
changes for requested changes, add test file
graytowne b14ddcd
Simplify and improve tests.
maciejkula 79c43f1
Merge pull request #1 from maciejkula/precision-recall
graytowne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import os | ||
|
||
import numpy as np | ||
|
||
import pytest | ||
|
||
from spotlight.evaluation import precision_recall_score | ||
from spotlight.cross_validation import random_train_test_split | ||
from spotlight.datasets import movielens | ||
from spotlight.factorization.implicit import ImplicitFactorizationModel | ||
|
||
RANDOM_STATE = np.random.RandomState(42) | ||
CUDA = bool(os.environ.get('SPOTLIGHT_CUDA', False)) | ||
|
||
|
||
@pytest.fixture(scope='module') | ||
def data(): | ||
|
||
interactions = movielens.get_movielens_dataset('100K') | ||
|
||
train, test = random_train_test_split(interactions, | ||
random_state=RANDOM_STATE) | ||
|
||
model = ImplicitFactorizationModel(loss='bpr', | ||
n_iter=1, | ||
batch_size=1024, | ||
learning_rate=1e-2, | ||
l2=1e-6, | ||
random_state=RANDOM_STATE, | ||
use_cuda=CUDA) | ||
model.fit(train) | ||
|
||
return train, test, model | ||
|
||
|
||
@pytest.mark.parametrize('k', [ | ||
1, | ||
[1, 1], | ||
[1, 1, 1] | ||
]) | ||
def test_precision_recall(data, k): | ||
|
||
(train, test, model) = data | ||
|
||
interactions = movielens.get_movielens_dataset('100K') | ||
train, test = random_train_test_split(interactions, | ||
random_state=RANDOM_STATE) | ||
|
||
precision, recall = precision_recall_score(model, test, train, k=k) | ||
|
||
assert precision.shape == recall.shape | ||
|
||
if not isinstance(k, list): | ||
assert len(precision.shape) == 1 | ||
else: | ||
assert precision.shape[1] == len(k) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this accept train interactions as well in the same way other metrics do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so that we can disregard the model giving high scores to known interactions. This reflects real-world system implementations.