Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TestingType into RustType #3

Merged
merged 3 commits into from
Jun 2, 2019
Merged

Conversation

macisamuele
Copy link
Owner

This PR renames json_trait_rs::TestingType into json_trait_rs::RustType.
This is done because external libraries might take advantage of it and it would be "not nice" to force them to have to use an additional feature.

NOTE: As TestingType or RustType depends on rust specific information (no other dependencies) it would not add much binary code in the final artifact.

@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files           8        8           
  Lines         537      537           
=======================================
  Hits          502      502           
  Misses         35       35
Impacted Files Coverage Δ
src/lib.rs 0% <ø> (ø) ⬆️
src/json_type.rs 89.47% <0%> (ø) ⬆️
src/index.rs 92.68% <100%> (ø) ⬆️
src/traits/_serde_json.rs 95.18% <100%> (ø) ⬆️
src/traits/_serde_yaml.rs 95.18% <100%> (ø) ⬆️
src/fragment.rs 100% <100%> (ø) ⬆️
src/traits/_json.rs 97.75% <100%> (ø) ⬆️
src/rust_type.rs 91.97% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9570ec8...e6e1874. Read the comment docs.

@macisamuele macisamuele merged commit 2db6c3e into master Jun 2, 2019
@macisamuele macisamuele deleted the maci-rename-TestingType branch July 25, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant