Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define json type to string trait #41

Merged
merged 2 commits into from
May 10, 2020

Conversation

macisamuele
Copy link
Owner

The goal of this PR is to ensure that :

  • JsonType instances are not forced to be Debug types
  • JsonType instances are ensured to be string-representable via a new trait (JsonTypeToString)

NOTE: JsonTypeToString does provide a default implementation but different trait implementations might override its implementation to use more performant solutions

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #41 into master will increase coverage by 2.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   94.23%   96.40%   +2.17%     
==========================================
  Files           9        9              
  Lines        1300     1337      +37     
==========================================
+ Hits         1225     1289      +64     
+ Misses         75       48      -27     
Impacted Files Coverage Δ
src/json_type.rs 96.45% <100.00%> (+11.67%) ⬆️
src/rust_type_impl.rs 91.50% <100.00%> (+6.08%) ⬆️
src/traits/_json.rs 98.72% <100.00%> (+0.03%) ⬆️
src/traits/_pyo3.rs 96.78% <100.00%> (+0.10%) ⬆️
src/traits/_serde_json.rs 97.41% <100.00%> (+0.09%) ⬆️
src/traits/_serde_yaml.rs 97.37% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32a6c7...142638a. Read the comment docs.

@macisamuele macisamuele force-pushed the maci-define-JsonTypeToString-trait branch from 31d9197 to 142638a Compare May 10, 2020 13:41
@macisamuele macisamuele merged commit cf6b6de into master May 10, 2020
@macisamuele macisamuele deleted the maci-define-JsonTypeToString-trait branch May 10, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant