Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command: drop go test -short mode #972

Merged
merged 1 commit into from
Feb 26, 2024
Merged

command: drop go test -short mode #972

merged 1 commit into from
Feb 26, 2024

Conversation

lufia
Copy link
Member

@lufia lufia commented Feb 26, 2024

For now, this flag did not reduce testing times ☺️

before

$ go test -v -run=Once -short
=== RUN   TestRunOnce
--- PASS: TestRunOnce (9.08s)
=== RUN   TestRunOncePayload
--- PASS: TestRunOncePayload (9.08s)
PASS
ok  	github.com/mackerelio/mackerel-agent/command	18.166s

$ go test -v -run=Once
=== RUN   TestRunOnce
--- PASS: TestRunOnce (9.07s)
=== RUN   TestRunOncePayload
--- PASS: TestRunOncePayload (9.07s)
PASS
ok  	github.com/mackerelio/mackerel-agent/command	18.147s

after

$ go test -v -run=Once
=== RUN   TestRunOnce
--- PASS: TestRunOnce (9.08s)
=== RUN   TestRunOncePayload
--- PASS: TestRunOncePayload (9.08s)
PASS
ok  	github.com/mackerelio/mackerel-agent/command	18.161s

@lufia
command: drop go test -short mode
012d25d 
For now, this flag did not reduce testing times
yseto
yseto approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@yseto yseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good.

@lufia lufia merged commit 308518b into master Feb 26, 2024
6 checks passed
@lufia lufia deleted the no-short branch February 26, 2024 10:11
@lufia lufia mentioned this pull request Feb 26, 2024
Merged
@mackerelbot mackerelbot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yseto yseto yseto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lufia @yseto