Add -diff option #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate difference of metrics that matches the expression.
Songmu
suggested changes
Dec 12, 2018
| func (p JSONPlugin) tempfilename() string { | ||
| // tempfiles have an unique name for each configuration. | ||
| filename := fmt.Sprintf("mackerel-plugin-json.%x", sha1.Sum([]byte(p.Prefix+p.URL))) | ||
| return filepath.Join(pluginutil.PluginWorkDir(), filename) |
There was a problem hiding this comment.
Using pluginutil is very good 👍
| } | ||
| defer os.RemoveAll(dir) | ||
| os.Setenv("MACKEREL_PLUGIN_WORKDIR", dir) // to separate tempfile for each test | ||
|
|
There was a problem hiding this comment.
Could you restore original "MACKERE_PLUGIN_WORKDIR" value with defer? It may cause adverse effects on other tests.
There was a problem hiding this comment.
Fixed at 3e5393b. Please confirm it.
Songmu
approved these changes
Dec 12, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I added
-diffoption to calculate metrics difference that like incremental counters.