Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use GitHub Actions #6

Merged
merged 2 commits into from
Nov 26, 2020
Merged

use GitHub Actions #6

merged 2 commits into from
Nov 26, 2020

Conversation

lufia
Copy link
Member

@lufia lufia commented Nov 26, 2020

I did.

astj
astj approved these changes Nov 26, 2020
View reviewed changes
.github/workflows/go.yml Outdated
- uses: actions/checkout@v2
- run: ./script/release
env:
GITHUB_TOKEN: ${{ secrets.MACKERELBOT_GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need mackerelbot token?
(Unless necessary, using secrets.GITHUB_TOKEN seems enough. ref https://github.com/mackerelio-labs/check-aws-cloudwatch-logs-insights/blob/main/.github/workflows/release.yml#L40 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will drop this env.

@lufia lufia merged commit 6331f56 into master Nov 26, 2020
@lufia lufia deleted the ghactions branch November 26, 2020 09:17
@lufia lufia mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astj astj astj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lufia @astj