feat: Use jest-editor-support to show messages etc #23
Conversation
|
This fixes an issue with TSC: jestjs/jest#4636 |
|
Found a way to simplify even further |
| @@ -2,7 +2,7 @@ | |||
| "compilerOptions": { | |||
| "declaration": true, | |||
| "declarationDir": "dist", | |||
| "lib": ["es5", "es2015"], | |||
| "lib": ["es5", "es2015", "es2017"], | |||
There was a problem hiding this comment.
Gives array more functions
src/index.ts
Outdated
|
|
||
| // console.log(reconciler) | ||
|
|
||
| // fails.forEach((failingFile) => fail(fileToFailString(failingFile))) |
There was a problem hiding this comment.
struggling to get the data the same as vscode-jest - which is surprising, they both do the exact same thing ( run jest, output json, send it into the reconciler)
| .map((r: any) => r.failureMessage) | ||
| .join('\n') | ||
| } | ||
| } |
There was a problem hiding this comment.
There's a version of this inside jest-editor-support that does more work
|
OK, this should be good as a rough first draft 👍 Without seeing how Danger JS deals with it, I can't really progress much further. |
| @@ -0,0 +1,70 @@ | |||
|
|
|||
There was a problem hiding this comment.
Used JSON2TS to stub out the JSON shape
|
At first glance, this looks awesome. Appreciate the contribution!
I can set up Danger on this repo in another PR/commit and then we can merge it in here to try it out. |
|
Yeah, good call 👍 |
|
#24 has been resolved and merged, so PRs should run Danger now. I tried to check out this branch locally and push a merge commit to your forked |
|
In theory you can, I also don't know how to do it - which is why I do branches, updating now |
|
interesting, looks like different versions of Jest test output has different keys available |
orta
force-pushed
the
master
branch
11 times, most recently
from
9df7f01
to
23d0bb5
Compare
|
I'm going to leave this alone for a bit to think, but TBH, I think there's a good argument for letting these tests fail in master also ( so that there's always a visual of what it looks like ) |
|
I like that output 💯 |
|
OK, I'm pretty convinced on this now, 👍 I've skipped the tests which fail. |
|
|
|
New release?! 💯 |
|
Yep! Give 1.1.0 a try and leave any feedback/bug reports in a new issue. ❤️ |
This is going to be a WIP PR, although Danger isn't on this repo, so that might make it hard for me to preview 🗡