Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make CapacityIndicator work with other values of splits, not only splits:10 #305

Merged
merged 18 commits into from
Feb 11, 2023
Merged

make CapacityIndicator work with other values of splits, not only splits:10 #305

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
808db3c
make CapacityIndicator work with other values of splits, not only wit…
schilken Sep 20, 2022
cdbe94f
add unit test for CapacityIndicator with splits 20
schilken Jan 15, 2023
752d9e2
add bugfix line to CHANGELOG
schilken Jan 15, 2023
defd14c
Merge branch 'GroovinChip:dev' into dev
schilken Jan 17, 2023
3e8cf2a
update version to 1.7.7, move change in CHANGELOG.md to version 1.7.7
schilken Jan 17, 2023
94de910
add test to check the number of filled segments of discrete CapacityI…
schilken Jan 27, 2023
a735e5a
fix warnings in copied sources mock_canvas.dart and recording_canvas.…
schilken Jan 27, 2023
6af7640
Merge branch 'dev' into dev
schilken Jan 27, 2023
91014d3
format new and changed files
schilken Jan 28, 2023
03348fb
Merge branch 'dev' of https://github.com/schilken/macos_ui into dev
schilken Jan 28, 2023
c6d4c03
Merge remote-tracking branch 'upstream/dev' into dev
schilken Feb 5, 2023
a4d2a6d
Merge branch 'dev' into dev
GroovinChip Feb 9, 2023
d114f87
Update CHANGELOG.md
schilken Feb 11, 2023
8e1418c
Merge remote-tracking branch 'upstream/dev' into dev
schilken Feb 11, 2023
8d88016
Merge remote-tracking branch 'origin/dev' into dev
schilken Feb 11, 2023
6f948c1
format indicators_page.dart, run flutter pub get to update lock files
schilken Feb 11, 2023
fbb990d
set dart < 3.0.0
schilken Feb 11, 2023
d2275f7
revert change of spec checksums in Podfile.lock
schilken Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/lib/pages/indicators_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class _IndicatorsPageState extends State<IndicatorsPage> {
CapacityIndicator(
value: sliderValue,
onChanged: (v) => setState(() => sliderValue = v),
splits: 20,
discrete: true,
),
const SizedBox(height: 20),
Expand Down
4 changes: 2 additions & 2 deletions lib/src/indicators/capacity_indicators.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class CapacityIndicator extends StatelessWidget {
}

void _handleUpdate(Offset lp, double width) {
double value = (lp.dx / width) * splits;
double value = (lp.dx / width) * 100 / splits;
onChanged?.call(value.clamp(0.0, 100.0));
}

Expand All @@ -108,7 +108,7 @@ class CapacityIndicator extends StatelessWidget {
if (width.isInfinite) width = 100;
final splitWidth = width / splits;
if (discrete) {
final fillToIndex = value / splits - 1;
final fillToIndex = (value / 100) * splits - 1;
return SizedBox(
width: width,
child: GestureDetector(
Expand Down