Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initialTime parameter to MacosTimePicker #490

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

Abbas1Hussein
Copy link
Contributor

@Abbas1Hussein Abbas1Hussein commented Oct 19, 2023

I have added the initialTime parameter to the MacosTimePicker widget, allowing to set an initial time value for the picker.

Minor Change: Added a void return type to OnDateChanged and OnTimeChanged.

The change has been tested to ensure proper functionality.

Checklist

  • Incremented the package version in pubspec.yaml (2.0.3).
  • Updated the CHANGELOG.md.
  • All code is properly formatted and comments are added.
  • Verified that there are no Dart analysis warnings.
  • Tested and confirmed that the changes work as expected.

@Abbas1Hussein Abbas1Hussein changed the title Time picker Adding initialTime parameter to MacosTimePicker Oct 19, 2023
@Abbas1Hussein
Copy link
Contributor Author

Hello team!, @GroovinChip Just checking in on the pull request
A month has passed. If there is anything I can do or if you need more information, just let me know.

Thanks.

@GroovinChip
Copy link
Collaborator

Hello team!, @GroovinChip Just checking in on the pull request

A month has passed. If there is anything I can do or if you need more information, just let me know.

Thanks.

Apologies; I have very little bandwidth these days. I'll do my best to get to this ASAP.

@Adrian-Samoticha Adrian-Samoticha merged commit 051bfff into macosui:dev Jan 21, 2024
3 of 4 checks passed
@Adrian-Samoticha
Copy link
Member

Alright. Merge conflicts resolved and PR merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants