Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beets: switch to python 3.10, part 1 #13005

Merged
merged 42 commits into from
Nov 21, 2021
Merged

beets: switch to python 3.10, part 1 #13005

merged 42 commits into from
Nov 21, 2021

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 16, 2021

Description

Here the first part of switching beets to python 3.10; it adds to all required python modules py310 subports.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 11.6 20G165 x86_64
Xcode 13.1 13A1030d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@lpsinger for port py-blinker, py-itsdangerous, py-xdg.
@ryandesign for port py-flask.
@amake for port py-fonttools, py-unicodedata2.
@petrrr for port py-jwt, py-oauthlib, py-xmltodict.
@harens for port py-langdetect.
@stromnov for port py-werkzeug.

@catap
Copy link
Contributor Author

catap commented Nov 17, 2021

Rebased to last master to re-run CI.

@catap
Copy link
Contributor Author

catap commented Nov 17, 2021

  Total number of ports parsed:	275 
  Ports successfully parsed:	275 

... seems that the only way to pass CI it is split this PR into a few smaller PR.

@pmetzger shall I split it?

@pmetzger
Copy link
Member

Yah, I would do the py-* port updates to 3.10 individually.

@catap
Copy link
Contributor Author

catap commented Nov 17, 2021

@pmetzger let me remove the last commit when :)

@catap catap changed the title beets: switch to python 3.10 beets: switch to python 3.10, part 1 Nov 17, 2021
@catap
Copy link
Contributor Author

catap commented Nov 18, 2021

@pmetzger / @mascguy what should I do with this PR? CI is failed because it is too long. I can split it to dozen of dedicated PR, or it can be merged as is.

@mascguy
Copy link
Member

mascguy commented Nov 18, 2021

@pmetzger / @mascguy what should I do with this PR? CI is failed because it is too long. I can split it to dozen of dedicated PR, or it can be merged as is.

Given how many great contributions you've made, I'm more than happy to test these locally. I'll try to do that tonight, if possible.

Assuming everything builds successfully, I'll merge after that's done.

@catap
Copy link
Contributor Author

catap commented Nov 18, 2021

@mascguy thanks!

You may use this branch https://github.com/catap/macports-ports/tree/beets-python310 which contains the one more commit with beets which was switched to python-3.10. You can use it to easy setup everything that I've changed here.

Thus, I can move this commit back to have delivered all this changes in one shot.

@mascguy
Copy link
Member

mascguy commented Nov 18, 2021

You may use this branch https://github.com/catap/macports-ports/tree/beets-python310 which contains the one more commit with beets which was switched to python-3.10. You can use it to easy setup everything that I've changed here.

Thus, I can move this commit back to have delivered all this changes in one shot.

Sounds great, that will make it much easier to install all of these ports at once!

@catap
Copy link
Contributor Author

catap commented Nov 18, 2021

@mascguy let me then return the beets commit back to this PR

@catap catap changed the title beets: switch to python 3.10, part 1 beets: switch to python 3.10 Nov 18, 2021
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all these added py310 subports tested in that they either pass the test-phase if present in the Portfile or upstream has declared support for Python 3.10? I don't think we want to en mass add subports without at least doing some basic tests to make sure they actually work.

@catap
Copy link
Contributor Author

catap commented Nov 18, 2021

@reneeotten I've installed beets from this branch and it works for a while. Also, beets had added to its CI py310 and it works and passes all tests.

I also did some basic tests for all added subports.

If you have any idea, I'd love to hear that.

@catap
Copy link
Contributor Author

catap commented Nov 18, 2021

@reneeotten I can split this PR to dozen of dedicated PR. Did it make any differences for you?

@catap
Copy link
Contributor Author

catap commented Nov 21, 2021

@pmetzger / @reneeotten to prove that the last CI changes works as expected, let me rebase this huge PR ;)

@mascguy
Copy link
Member

mascguy commented Nov 21, 2021

There's been plenty of discussion, review, pre-merge testing, etc. So let's merge.

In the unlikely event that there are any issues with the new Python 3.10 subports, I'll assist with fixing them ASAP.

And thanks again for all of your work Kirill. Great stuff!

@mascguy mascguy merged commit a46616a into macports:master Nov 21, 2021
@catap catap deleted the beets branch November 21, 2021 18:33
@mascguy
Copy link
Member

mascguy commented Nov 21, 2021

Kirill, it looks like there are two more Python ports which need support for 3.10, specifically for Beets: py-gmusicapi and py-responses. Are those on your to-do list?

@catap
Copy link
Contributor Author

catap commented Nov 21, 2021

@mascguy py-gmusicapi is required for not devel support and needs for this port was remove beetbox/beets#4089 => no need to update.

py-responses was added with unit tests and I'll do it right away :)

@mascguy
Copy link
Member

mascguy commented Nov 21, 2021

@mascguy py-gmusicapi is required for not devel support and needs for this port was remove beetbox/beets#4089 => no need to update.

py-responses was added with unit tests and I'll do it right away :)

No rush, just trying to help you prepare for the move to 3.10. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.