-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beets: switch to python 3.10, part 1 #13005
Conversation
Rebased to last master to re-run CI. |
... seems that the only way to pass CI it is split this PR into a few smaller PR. @pmetzger shall I split it? |
Yah, I would do the py-* port updates to 3.10 individually. |
@pmetzger let me remove the last commit when :) |
Given how many great contributions you've made, I'm more than happy to test these locally. I'll try to do that tonight, if possible. Assuming everything builds successfully, I'll merge after that's done. |
@mascguy thanks! You may use this branch https://github.com/catap/macports-ports/tree/beets-python310 which contains the one more commit with Thus, I can move this commit back to have delivered all this changes in one shot. |
Sounds great, that will make it much easier to install all of these ports at once! |
@mascguy let me then return the beets commit back to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all these added py310 subports tested in that they either pass the test-phase if present in the Portfile or upstream has declared support for Python 3.10? I don't think we want to en mass add subports without at least doing some basic tests to make sure they actually work.
@reneeotten I've installed I also did some basic tests for all added subports. If you have any idea, I'd love to hear that. |
@reneeotten I can split this PR to dozen of dedicated PR. Did it make any differences for you? |
@pmetzger / @reneeotten to prove that the last CI changes works as expected, let me rebase this huge PR ;) |
There's been plenty of discussion, review, pre-merge testing, etc. So let's merge. In the unlikely event that there are any issues with the new Python 3.10 subports, I'll assist with fixing them ASAP. And thanks again for all of your work Kirill. Great stuff! |
Kirill, it looks like there are two more Python ports which need support for 3.10, specifically for Beets: |
@mascguy
|
No rush, just trying to help you prepare for the move to 3.10. :-) |
Description
Here the first part of switching beets to python 3.10; it adds to all required python modules py310 subports.
Type(s)
Tested on
macOS 11.6 20G165 x86_64
Xcode 13.1 13A1030d
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?