-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gocryptfs: Fix build for arm64 #13069
Conversation
* Introduce doc variant, which is enabled by default. * Use go-md2man instead of pandoc on arm64 as this arch is not yet supported by upstream yet [1]. [1]: jgm/pandoc#6960
Would md2man work better than pandoc on all platforms? |
No, because the manpage generated by md2man has some formatting issues, which is why I'd like to use it only when pandoc is not available. |
Makes sense. |
We previously had arm64 copy over and install the x86_64 binary of pandoc, which runs just fine on arm64 and solves this issue until ghc is updated to support arm macs. It was packaged like this: https://packages.macports.org/pandoc/pandoc-2.10.1_0.darwin_20.arm64.tbz2 but somewhere along the line that was scrubbed out, and I guess we're just broken again. |
Actually, Josh also said that MacPorts would automatically see the x86_64 version as runnable on arm64 Macs, and install that x86_64 version without any intervention by the user if it existed on the packages server. Or that was supposed to be how it worked, if I understood the logic correctly. |
Thanks @MarcelBochtler ! The change is working on M1 now |
@kencu I investigated this and it seems to be that direct installations of x86_64 ports works on ARM64 devices.
This issue is also outlined in this ticket: https://trac.macports.org/ticket/63092 |
Hmm. I wonder if we might "depends_skip_archcheck pandoc" then, as it is just a tool and we don't care if it has a matching architecture to the port being built. that may not be the exact line to use in the Portfile, but it is something similar to that.. |
Description
supported by upstream yet 1.
Type(s)
Tested on
macOS 11.6.1 20G224 x86_64
Xcode 13.1 13A1030d
Verification
Have you
port lint
?sudo port -vst install
?