Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glslang: add pkg-config file #21006

Merged
merged 1 commit into from
Oct 23, 2023
Merged

glslang: add pkg-config file #21006

merged 1 commit into from
Oct 23, 2023

Conversation

jasonliu--
Copy link
Contributor

Description

This patch has also been submitted upstream; when it gets added to the glslang codebase, we can delete this patch.

KhronosGroup/glslang#3371

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.6 17G14042 x86_64
Xcode 10.1 10B61

macOS 10.11.6 15G22010 x86_64
Xcode 8.2.1 8C1002

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@judaew for port glslang.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Oct 21, 2023
judaew
judaew approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@judaew judaew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution 🌟

@judaew judaew merged commit 9394aa4 into macports:master Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judaew judaew judaew approved these changes

Assignees

@judaew judaew

Labels
maintainer: open Affects an openmaintainer port type: enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonliu-- @macportsbot @judaew