Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaradio: new port, version 0.6.1 #6539

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

vsergeev
Copy link
Contributor

@vsergeev vsergeev commented Mar 8, 2020

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.15.3
Xcode 11.3.1

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Travis Build #10661 Failed.

Lint results
--->  Verifying Portfile for luaradio
--->  0 errors and 0 warnings found.

Port luaradio success on xcode10.3. Log
Port luaradio's dependencies fail on xcode9.4. Log
Port luaradio success on xcode8.3. Log

science/luaradio/Portfile Outdated Show resolved Hide resolved
science/luaradio/Portfile Outdated Show resolved Hide resolved
@vsergeev
Copy link
Contributor Author

Thanks for the feedback @mf2k, I've updated the Portfile with the requested changes.

I would just add as a comment or observation that it's surprising to me that fields like name and version aren't explicitly required in general. I see now that the github PortGroup will specify them for you, but this implies that the choice of standard fields to provide or to omit depends on specific knowledge of the PortGroup being used, while I expected the github PortGroup would behave more like a fetch helper extension to the standard package fields.

@macportsbot
Copy link

Travis Build #10671 Errored.

Lint results
--->  Verifying Portfile for luaradio
--->  0 errors and 0 warnings found.

Port luaradio success on xcode10.3. Log
Port luaradio success on xcode8.3. Log

The build timed out.

@mf2k
Copy link
Contributor

mf2k commented Mar 10, 2020

Let's give time to other committers to review this.

@vsergeev
Copy link
Contributor Author

vsergeev commented Mar 21, 2020

Any updates on this? -- would love to have this merged so I could close some issues on my end.

@mf2k mf2k merged commit 993f216 into macports:master Mar 22, 2020
@vsergeev
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants