Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.2.1456 - shift+o broken when used on top line that wraps to multiple screen lines #1083

Closed
AbePralle opened this issue Sep 8, 2020 · 1 comment
Closed

8.2.1456 - shift+o broken when used on top line that wraps to multiple screen lines #1083

AbePralle opened this issue Sep 8, 2020 · 1 comment
Milestone
snapshot-166

Comments

@AbePralle
Copy link

AbePralle commented Sep 8, 2020 •
edited
Loading

Describe the bug
SHIFT+O does not work properly when used on the top line of the buffer and the top line wraps to occupy two or more screen lines. It clears the top screen line instead of shifting it down. Undo does not work properly after that command.

To Reproduce
Detailed steps to reproduce the behavior:

  1. Run mvim --clean
  2. Type in any placeholder text to make the top line occupy multiple screen lines. Add one or two more logical lines as well to see the Undo corruption in steps 5 & 6.
  3. Escape to command mode. With the cursor on the top line, press SHIFT+O.
  4. The top screen line will clear instead of shifting down.
  5. Press ESCAPE and then u to undo.
  6. The top line is restored but one or more lines under it disappears. The number of following lines that disappear is equal to the number of screen lines that the top line occupies, minus one.

Expected behavior
SHIFT+O should work a long top line the same as on any other line. Note: this bug does not occur on the previous release, 8.2.539.

Environment

  • Vim 8.2.1456
  • macOS 10.15.5
@ychin ychin added this to the snapshot-166 milestone Sep 8, 2020
@ychin
Copy link
Member

ychin commented Sep 8, 2020

I think this is fixed upstream in v8.2.1488 (9dc1917). Will be fixed next release in release 166.

@ychin ychin closed this as completed Sep 8, 2020
ychin added a commit that referenced this issue Sep 21, 2020
@ychin
MacVim Snapshot 166
ab85313 
Updated to Vim 8.2.1719.

Features
====================

Touch Bar improvements
--------------------

Touch Bar now supports submenus, and allows mixed icon/text displays
using `tmenu`. When in edit modes (e.g. insert), it will also display an
emoji picker as well. See `:help touchbar` for documentation. #1084

Fixes
====================

- Window menu no longer shows duplicate "Enter Full Screen" or "Tile
  Window to Left of Screen" entries whenever the user switches among
  different MacVim windows. #566 #992
- Fix issue where going to full screen mode when titlebar appearance is
  set to "hidden" would result in lost focus of the window. #1078
- The password dialog box when using `:!sudo` or other commands that
  require password entry (`macvim-askpass`) will no longer focus on
  Finder, and will keep the focus on MacVim. #1091
- Fix minor wrong tooltip in the "Appearance" preference pane. #1087
- "General" preference pane will now be correctly sized when Sparkle
  updater is disabled (e.g. Homebrew builds). #1089
- Misc issues were fixed by Vim upstream, e.g. `vimgrep` causing a
  crash, and odd behaviors with using Shift-O on the first line. #1082
  #1083

Compatibility
====================

Requires macOS 10.9 or above.

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.8
- Ruby 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
snapshot-166
Development

No branches or pull requests
2 participants
@AbePralle @ychin