Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coarse MacVim version reporting in about, update checks and github releases #1293

Closed
2 of 7 tasks
eirnym opened this issue Sep 19, 2022 · 2 comments · Fixed by #1396
Closed
2 of 7 tasks

Coarse MacVim version reporting in about, update checks and github releases #1293

eirnym opened this issue Sep 19, 2022 · 2 comments · Fixed by #1396
Labels
Updater Issues related to Sparkle updater
Milestone
Release 177

Comments

@eirnym
Copy link
Contributor

eirnym commented Sep 19, 2022

Steps to reproduce

  1. Look on the about dialog box and it shows "Custom version 9.0.472 (174)`. close it
  2. Open Check for updates menu. it shows "MacVim 9.0.472 is the newest version"
  3. Check GitHub releases page, it shows "MacVim Release 174"

Expected behaviour

I expect all sources show more or less the same text, e.g. "MacVim Release 9.0.472 (174)". This is required for a user to have a strong visual connection between versions seen in all of these sources

I do NOT expect that :version command is touched in any way.
I do NOT expect that HomeBrew/MacPorts versioning is touched in any way.

Version of Vim and architecture

arm64

Environment

Operating system: macOS Monterey 12.6
Terminal: GUI only

How MacVim was installed

from GitHub releases to the default location

Logs and stack traces

No response

Vim configuration where issue is reproducable

No response

Issue has been tested with given configuration

  • by running MacVim.app from GUI macOS interface
  • by running vim/gvim/etc installed by MacVim
  • by running other versions of vim (e.g. /usr/bin/vim)

Issue has been tested with no configuration

  • by running mvim --clean (or gvim, supplied by MacVim distribution)
  • by running vim --clean (in terminal, supplied by MacVim distribution)
  • by running vim --clean (in terminal, other suppliers, e.g. /usr/bin/vim)

Other conditions

  • The both Homebrew packages "vim" and "macvim" are installed
@ychin
Copy link
Member

ychin commented Sep 19, 2022

Yeah this is a good point. We do see people getting confused about version numbers from time to time. For (2), the “check for updates” dialog box is controlled by Sparkle. I filed an issue to see if we can customize the display of it (sparkle-project/Sparkle#2267), but in other places too we should be a little more consistent in how we present Vim version and MacVim release number.

@eirnym
Copy link
Contributor Author

eirnym commented Sep 19, 2022

Thank you @ychin for the fast response to it, I'll monitor that issue as well

ychin added a commit to ychin/macvim that referenced this issue Feb 3, 2023
@ychin
Report better version in About MacVim, and store last used version
02092cf 
Use a better format for the version reporting in the "About MacVim" page
to be clear what's the Vim version, and what's specifically the MacVim
release number.

Also, store the last used MacVim version number. This isn't used right
now but may be used later for showing up a "What's New" page when
updating to a new version, primarily for non-Sparkle users (e.g.
Homebrew builds) so they can still be notified when something changed.
Storing this number now allows us to know in a later build whether the
user has upgraded to the build or starting a new build from fresh (where
we may not want to show the "What's New" page as everything would be
new).

Part of addressing macvim-dev#1293
@ychin ychin mentioned this issue Feb 3, 2023
Merged
@ychin ychin added this to the Release 177 milestone Feb 21, 2023
@ychin ychin added the Updater Issues related to Sparkle updater label Feb 21, 2023
ychin added a commit to ychin/macvim that referenced this issue Mar 20, 2023
@ychin
Use more descriptive version string in Sparkle 2
c311abc 
Sparkle 2.4 added support for customizing the displayed version string
instead of just showing the "display version" from the manifest (see
sparkle-project/Sparkle#2267). Since MacVim
has a somewhat non-standard usage of bundle vs display version (bundle
is release number, and display version is the upstream Vim version), we
really want to show both to the user, in a concise manner. Support this
customization so it looks like "r123 (Vim 9.1.2345)" (here, "123" is the
bundle version / release number, and "9.1.2345" is the display version /
Vim version).

Fix macvim-dev#1293
@ychin ychin mentioned this issue Mar 20, 2023
Merged
ychin added a commit that referenced this issue Jul 10, 2023
@ychin
MacVim r177
d6a1a39 
Updated to Vim 9.0.1677

Announcements
====================

Website
--------------------

The official website for MacVim is now https://macvim.org. Previously it just
forwarded to https://macvim-dev.github.io/macvim/. You can also read the MacVim
documentation at https://macvim.org/docs/gui_mac.txt.html. #1385

Features
====================

Updater / What's New page
--------------------

There is now a "What's New" page that will automatically be shown whenever
MacVim detected that it has been updated to a new version (can be disabled in
Settings). The page will also include all the release notes if you have
updated across multiple versions. This feature is useful for users who turned
on "Automatically install updates" or installs MacVim through other methods
like Homebrew but would still like to see the release notes when a new version
comes out. You can also access it through the Help menu. #1414

MacVim should now report its version in a much more consistent manner in the
"About MacVim" page and when the updater reports there is a new version. It
should look something like "r176 (Vim 9.0.1276)" where "r176" is the MacVim
release number and the 9.0.1276 is the bundled Vim version. #1293 #1393

Sparkle (updater for MacVim) is now updated to 2.4.2. #1416

New Vim features
--------------------

- New bundled colorschemes: wildcharm/retrobox/sorbet/zaibatsu (vim/vim#12163)
- File encryption now has a new `cryptmethod`: `xchacha20v2`, which is designed
  to be more forward compatible with future Vim versions than `xchacha20`.
  (v9.0.1481)
- `switchbuf` works for more commands. (v9.0.1546)
- Statusline now supports multiple alignment "%=" items. (v9.0.1300)
- New UTF-16 utility functions (`strutf16len` and `utf16idx`) (v9.0.1485)
- Misc 'smoothscroll' bugs fixes

General
====================

* Removed non-Unicode localization files, which helps cut down on app size. #1397
* Miscellaneous documentation fixes. #1415 #1375 #1386 #1363 (by @dkav)
* The disk image for MacVim (MacVim.dmg) is now in APFS and uses better
  compression for better efficiency. #1409

Fixes
====================

* Printing a file in macOS 13 Ventura (using `:hardcopy` or File→Print) should
  work again. #1390
* Fixed a broken symlink to XPCServices in the Sparkle framework. #1367
* Fixed MacVim to not throw (safe) Objective C exceptions when quitting. #1371
* Fixed welcome message not being aligned properly in Simplified Chinese and
  show the Vim 9 prompt. #1381
* Removed some unnecessary test files in the runtime folders which were
  included erroneously. #1418

Scripting
====================

- Scripting languages versions:
    - Python is now built against 3.11, up from 3.10.

Compatibility
====================

Requires macOS 10.9 or above. (10.9 - 10.12 requires downloading a
separate legacy build)

Script interfaces have compatibility with these versions:

- Lua 5.4
- Perl 5.30
- Python2 2.7
- Python3 3.11
- Ruby 3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Updater Issues related to Sparkle updater
Projects
None yet
Milestone
Release 177
Development

Successfully merging a pull request may close this issue.

Use more descriptive version string in Sparkle 2 ychin/macvim
2 participants
@eirnym @ychin