Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "open" command (when called from MacVim) is slower since MacOS Mojave #763

Closed
tobireif opened this issue Oct 19, 2018 · 25 comments
Closed

The "open" command (when called from MacVim) is slower since MacOS Mojave #763

tobireif opened this issue Oct 19, 2018 · 25 comments
Labels
10.14 Mojave
Milestone
snapshot-154

Comments

@tobireif
Copy link

tobireif commented Oct 19, 2018 •
edited
Loading

The "open" command (when called from MacVim) is slower since MacOS Mojave.

I have eg these lines in my .vimrc:

" Open File:
:map gf :!gvim <cfile><CR>

" Go to URL ("Go to Link"):
:map gl :!open -a "Google Chrome" "<cWORD>"<CR>
@ychin
Copy link
Member

ychin commented Nov 1, 2018

@tobireif I can confirm this is happening. I don't have High Sierra installed to test unfortunately, but was it instantaneous before Mojave?

@tobireif
Copy link
Author

tobireif commented Nov 1, 2018 •
edited
Loading

Thanks for investigating!

Yes, it used to be very usable in a fast workflow. Now it's slow which is an issue, eg when I try to open several links in a row ...

@ychin
Copy link
Member

ychin commented Nov 2, 2018

I tried building MacVim with the latest changes under Xcode 10 and the issue seems to be gone somewhat. I don't know where the issue lied or whether some change actually fixed it or not, but after next time we do a release I'll ping here again to see if you see that issue.

@tobireif
Copy link
Author

tobireif commented Nov 2, 2018

Thanks!

@alswl
Copy link

alswl commented Nov 9, 2018 •
edited
Loading

This bug was fixed for me on mojave 10.14.1 (18B75) .

updated: oops, it did not.

@tobireif
Copy link
Author

(Yep, the issue persists here as well, on the same OS version.)

@alswl alswl mentioned this issue Nov 14, 2018
Closed
@tobireif
Copy link
Author

Perhaps someone could report it to Apple at https://bugreport.apple.com/web/ .

@ychin
Copy link
Member

ychin commented Dec 3, 2018

Are you using homebrew or the distributed release binaries @tobireif ?

@tobireif
Copy link
Author

tobireif commented Dec 3, 2018

I had installed MacVim (quite a while ago) from https://github.com/macvim-dev/macvim/releases , and since then it updates itself.

@ychin ychin mentioned this issue Dec 4, 2018
Closed
@ychin
Copy link
Member

ychin commented Dec 5, 2018

Ok. I think the issue is somehow because MacVim is currently not signed by an Apple Developer ID, which… for some reason means calling open is slow. I will investigate #517 to see if I can get an developer ID to sign it, plus see if Apple could fix the issue (there are users who use MacVim by building locally hence shouldn't be forced to self-sign their apps).

@tobireif
Copy link
Author

tobireif commented Dec 5, 2018

Sounds good!

@tobireif
Copy link
Author

I hope it will be possible to fix this 😀

@chdiza
Copy link
Contributor

chdiza commented Dec 14, 2018

I don't see this delay on Mojave, but then again I have SIP disabled and Gatekeeper set to allow everything.

@adudek16
Copy link

I can confirm that opening windows via the app is definitely broken under 10.14.2. If I run mvim from the cli a new window opens up quickly. I have 2 macs I can test with one with 10.14.2 and one with 10.13.6. I install from Binaries mostly.

@ychin ychin added this to the snapshot-154 milestone Dec 19, 2018
@ychin
Copy link
Member

ychin commented Dec 19, 2018 •
edited
Loading

The next binary release will be signed by an Apple Developer ID which will (for some reason) fix this. Use the tagged milestone in this issue to track progress and ETA.

@adudek16
Copy link

Great. I did some testing and installed 151 to the desktop. Launching from there is as expected, but when installed into applications, then it is slow. I repeated same test with 153 and the behavior is the same. From the Desktop - speedy, from Applications - slow if at all.

@ychin
Copy link
Member

ychin commented Dec 19, 2018

Hmm, FWIW that's not the case for me. Compiled for 10.13 or signed application: Fast either way (desktop or Applications). Unsigned app built for 10.14: Slow either way. I don't think the behavior manifests depending on where you are running the app bundle form so I'm surprised you saw that.

@tobireif
Copy link
Author

The next binary release will be signed by an Apple Developer ID which will (for some reason) fix this.

Thank you!

@tobireif
Copy link
Author

tobireif commented Jan 8, 2019

I currently have the latest MacVim version "Custom Version 8.1.577 (153)". Which version should fix the issue? Thanks in advance :)

@ychin
Copy link
Member

ychin commented Jan 8, 2019

You need 154 which is not released yet. Use the tagged milestone to track the date it will be released (which is within this month).

@tobireif
Copy link
Author

tobireif commented Jan 9, 2019

Thanks!

@badouralix badouralix mentioned this issue Jan 28, 2019
Closed
@will-stone will-stone mentioned this issue Jan 28, 2019
Closed
ychin added a commit to ychin/macvim that referenced this issue Feb 4, 2019
@ychin
MacVim Snapshot 154
644ca93 
Vim patch 8.1.873

Targets macOS 10.8+

General:

- MacVim binary is now signed by a Developer ID (macvim-dev#517). This makes it
  easier to download and run the app without security warnings.
    - This also fixes an issue where invoking external programs via
      `:!open` was slow in Mojave. macvim-dev#763
- Ruby version has been updated from 2.5 to 2.6.

Fixes:

- Scrollbars are no longer misplaced when resizing window macvim-dev#827
- Fix rendering performance issues for commands (e.g. `:version`,
  `:echo`, or `:!`) that echo text in Mojave macvim-dev#840
- MacVim now properly asks for permission to use AppleEvent (ODB Editor
  Suite requires that to work) macvim-dev#822
- Fix borderless window mode in pre-Mojave versions macvim-dev#828

Script interfaces have compatibility with these versions:

- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.6
@ychin
Copy link
Member

ychin commented Feb 4, 2019

Latest release (https://github.com/macvim-dev/macvim/releases/tag/snapshot-154) now signs the app. The open delay should be gone.

@ychin ychin closed this as completed Feb 4, 2019
@tobireif
Copy link
Author

tobireif commented Feb 4, 2019

Thanks! I think the severe delay is gone. (Right at the start after opening a link there still is a certain amount of lag, but I don't know whether that's fixable.)

@ychin
Copy link
Member

ychin commented Feb 4, 2019 •
edited
Loading

Hmm I don't see any delays anymore on my end. Let me know if it's really long. It should behave similar to older non-Mojave versions.

@tobireif
Copy link
Author

tobireif commented Feb 5, 2019

The issue where it takes really long (since Mojave) definitely is fixed. Thank you!

@aganders3 aganders3 mentioned this issue Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.14 Mojave
Projects
None yet
Milestone
snapshot-154
Development

No branches or pull requests
5 participants
@tobireif @alswl @ychin @chdiza @adudek16