Update icon to macOS 11 style #1054
Conversation
|
Here's an alternative version that aligns with the original icon better. Option 2
|
|
Thanks for the update! Between the original and alt version is there one you prefer? I appreciate the update but I may let this sit a little bit when macOS 11 Big Sur is still in beta to see if others have opinions and let me take a look at Apple's guidelines in the meantime. |
|
Sounds good @ychin. I think it makes sense to gather more feedback during the Bir Sur beta period so that everyone feels confident by the time the macOS 11 ships. I initially liked the first version better, but after refining the second version more I prefer that one. Since it stays more true to the original Vim logo, that's probably the more sensible (and least controversial) direction. |
|
Just some immediate feedback / thoughts: I like option 1 better. The second option aligns better with the original Vim logo but it looks… kind of off? Like we just introduced a white squircle border for no good reason with yet another solid color border inside it. It in a way reminds me of Vim in that we pile on new features but trying to keep backwards compatibility at all cost, but seems like at first glance at least the first icon seems cleaner. The other thing that jumped at me was how strong the 3D shading shadow is. The drop shadow is fine, but the "V" almost feels too… 3D to me. I'm still not sure if I'm put off by it itself or just the new Big Sur aesthetics, and I'm going through the list of icons and the official recommendation to see how this fits in, and so far it seems… inconclusive to me and seems like some icons have this strong 3D shading effect (e.g. Messages, App Store) while others still look flat with a squircle around the icon (e.g. Apple TV, Apple Music). So I'm not sure yet. Maybe will need to wait till I (and others) get a beta version installed and can try them side-by-side, and to let it sink in a bit first. |
|
Here's another variant on the first option, but with the shading dialed way down. Option 3
|
|
I perfect the most Option 2. I like that macOS is going back to 3d effects in icons |
Option 4
|
|
👍 for Option 2 but with the shading dialed way down == Option 4 with white background color. |
|
Sorry for the delay - I was on vacation last week. Option 5
|
|
Hi, @jasonlong , do you mind if you could provide all the different options' |
|
Just pinging again. @jasonlong , do you mind providing the different options as |
|
@ychin Sorry for the delay. Here's a link to the different |
|
Just trying out to see how the 5 options look relative to the other icons in the Big Sur beta: Option 1:
Option 2:
Option 3:
Option 4:
Option 5:
After seeing it side-by-side, I think I'm still not a huge fan of Option 5 (even though it seems to be popular with the limited voting we have). In particular, most default icons seems to have a simple "background color + thing in the middle" design, where as Option 2/5 is a thing within a thing within a thing. But I feel like Option 5 looks a little better in the 2nd screenshot (next to the Home app) compared to the first one. The white background also makes the V's contrast hard to see. In that sense I actually like Option 2 more than 5. I think Option 3 remains my favorite, whereas I think Option 4 is pretty bad. Also, Apple seems to not be terribly consistent in their 3D shading effect. App Store / Messages' icons use a fairly strong shading effect, but Music / News look pretty flat. The official HIG guidelines only suggests using it so 🤷 . @jasonlong what do you think? Which one do you personally think look the best? Going to do a second round of voting below. Feel free to both vote up or down on more than one icon! Kind of doing a poor-man's approval/ranked voting this way. |
|
Vote Option 1:
|
|
Vote option 2
|
|
Vote Option 3
|
|
Vote Option 4
|
|
Vote Option 5
|
|
Thanks for putting these comparisons together @ychin.
Agreed, this has made these explorations challenging trying to align the treatment w/ the default icons.
Seeing them all in context, I tend to agree with you. Sometimes I feel like that one is too flat, but I feel like that one looks better than the really shaded Option 1. If we want to try some shading options in-between, I'm happy to build some. |
|
The V a little further to the right?
|
|
@ychin With Big Sur out, can I help at all getting the icon update ready to ship? I can update this PR to use Option 3 above if you like. |
|
@jasonlong Yes please update to Option 3. I was a little busy with work and got a little behind on making sure MacVim is ready for Big Sur! Just to make sure #1054 (comment) is addressed. I personally think the alignment in the original Option 3 looks fine, but it's because of how the "V" looks in the font that it looks a little offset to the left. I think it's fine to leave it as is, but if you want to shift it to the right I'm fine with that too. |
|
Ok, the branch has been updated here and I tried to better optically center the mark in the container. The final version looks like this:
|
|
Merged! Thanks for the update. |
Updated to Vim 8.2.2127. *Note*: This release doesn't natively support Apple Silicon / M1 yet, but does work under Rosetta. See below. Features ==================== Big Sur / macOS 11 -------------------- - MacVim now has an updated app icon (#1054), and preference pane / toolbars have been updated to match Big Sur's interface guidelines. (#1128) - Fixed Touch Bar warnings when launching MacVim from the terminal. #1114 - SF Symbol characters will show up properly as double-width as most of these icons would take up more than one column. Note that these characters are specific to macOS and would not work in other platforms. #1129 Renderer / scrolling performance improvements -------------------- The Core Text renderer has been rewritten and is now much faster! Scrolling should not stutter and lag like before and generally it should feel a lot smoother now. Thanks to Sidney San Martín (@s4y) for the contribution. #858 With this change, the non-Core-Text renderer is now considered deprecated. The old renderer is accessible either through the Preference Pane (under Advanced) or by setting the defaults "MMRenderer" to 0. It works for now, but it will be removed in a future update as it has known bugs. Menu Localization -------------------- Menus are now localized, see `:h langmenu` for how Vim menu localization works. You can use `set langmenu=none` to turn it off if you would like. #1099 There still exists a few menu items that are not localized, and the general MacVim GUI is not localized as well. If you would like to help, please use #1102 to coordinate with MacVim dev team. Getting help / Help menu -------------------- - Help menu's search bar now searches Vim documentation as well! See #1095. - Vimtutor is now bundled with MacVim, and you can access vimtutor from the Help menu (#1096). There is also a link to the latest release notes as well (#1131). General ==================== - This release does not contain a native universal app for Apple Silicon / M1 Macs yet. The release binary will still work under Rosetta, which should provide enough performance, but if you use Python/etc plugins, you need to make sure you have x86 versions of Python/etc installed (which is still the default for Homebrew as of this release). MacVim is buildable under Apple Silicon, so if you need a native binary, you could build it yourself by downloading the source from the Github repository. See #1136 for progress on releasing a universal app for Apple Silicon. - MacVim has enabled the Github Discussions feature, which serves as a good spot for general discussions and questions. See #1130 and check it out! Fixes ==================== - Launching MacVim from the Dock with locales that use "," for decimal separators now works correctly. #11 (Vim 8.2.1738) - `WinBar` menus (which are used by plugins like vimspector) now work properly and don't create dummy menu items. #918 - Using `:browse tabnew` no longer crashes MacVim in terminal mode. #1107 (Vim 8.2.1842) Misc ==================== - Scripting languages versions: - Python is now built against 3.9, up from 3.8. - Lua is now built against 5.4, up from 5.3. Compatibility ==================== Requires macOS 10.9 or above. Script interfaces have compatibility with these versions: - Lua 5.4 - Perl 5.18 - Python2 2.7 - Python3 3.9 - Ruby 2.7
Updated to Vim 8.2.2127. *Note*: This release doesn't natively support Apple Silicon / M1 yet, but does work under Rosetta. See below. Features ==================== Big Sur / macOS 11 -------------------- - MacVim now has an updated app icon (#1054), and preference pane / toolbars have been updated to match Big Sur's interface guidelines. (#1128) - Fixed Touch Bar warnings when launching MacVim from the terminal. #1114 - SF Symbol characters will show up properly as double-width as most of these icons would take up more than one column. Note that these characters are specific to macOS and would not work in other platforms. #1129 Renderer / scrolling performance improvements -------------------- The Core Text renderer has been rewritten and is now much faster! Scrolling should not stutter and lag like before and generally it should feel a lot smoother now. Thanks to Sidney San Martín (@s4y) for the contribution. #858 With this change, the non-Core-Text renderer is now considered deprecated. The old renderer is accessible either through the Preference Pane (under Advanced) or by setting the defaults "MMRenderer" to 0. It works for now, but it will be removed in a future update as it has known bugs. Menu Localization -------------------- Menus are now localized, see `:h langmenu` for how Vim menu localization works. You can use `set langmenu=none` to turn it off if you would like. #1099 There still exists a few menu items that are not localized, and the general MacVim GUI is not localized as well. If you would like to help, please use #1102 to coordinate with MacVim dev team. Getting help / Help menu -------------------- - Help menu's search bar now searches Vim documentation as well! See #1095. - Vimtutor is now bundled with MacVim, and you can access vimtutor from the Help menu (#1096). There is also a link to the latest release notes as well (#1131). General ==================== - This release does not contain a native universal app for Apple Silicon / M1 Macs yet. The release binary will still work under Rosetta, which should provide enough performance, but if you use Python/etc plugins, you need to make sure you have x86 versions of Python/etc installed (which is still the default for Homebrew as of this release). MacVim is buildable under Apple Silicon, so if you need a native binary, you could build it yourself by downloading the source from the Github repository. See #1136 for progress on releasing a universal app for Apple Silicon. - MacVim has enabled the Github Discussions feature, which serves as a good spot for general discussions and questions. See #1130 and check it out! Fixes ==================== - Launching MacVim from the Dock with locales that use "," for decimal separators now works correctly. #11 (Vim 8.2.1738) - `WinBar` menus (which are used by plugins like vimspector) now work properly and don't create dummy menu items. #918 - Using `:browse tabnew` no longer crashes MacVim in terminal mode. #1107 (Vim 8.2.1842) Misc ==================== - Scripting languages versions: - Python is now built against 3.9, up from 3.8. - Lua is now built against 5.4, up from 5.3. Compatibility ==================== Requires macOS 10.9 or above. Script interfaces have compatibility with these versions: - Lua 5.4 - Perl 5.18 - Python2 2.7 - Python3 3.9 - Ruby 2.7
|
I know this issue is closed, but I'd like to suggest something like the "overhang" versions proposed for VS Code in this comment, maybe with the bottom and/or the right tip of the V sticking out a bit from the squircle. Sadly I don't have the design skills to mock that up. Would anyone care to take a shot at it? |
|
Hi, I appreciate the comment but I'm not sure I'm buying the overhang design. Also, the Vim's "V" has always been level at the top, so to make it overhang you would have to change the iconography of it as well to have some part poke out. I think the overhang is usually designed for an object laid on top of the squircle, not for a letter (https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon). If you have more thoughts though feel free to discuss at #1140 since people love to discuss design changes :) . |
|
the default icon is highly new for me and an icon in docker looks very different than on a GitHub page. I love the diamond was before and new icon looks flat to me. Is it possible in macOS to change an icon from app settings like I can do it in iOS? If yes, is it possible to add all icons and let user decide which icon to show? I somewhat want an option, to decide. |
|
@eirnym See the discussion on #1140 (we should focus on using that thread to discuss icon change). No, macOS doesn't allow for multiple icons for an app so it has to be one. You could change it yourself in Finder and the OS will remember it, but we don't have a way for MacVim to bundle multiple icons and let you choose, unfortunately. With most things icon or interface change related, I think it takes time to adapt. I'm open to see how the new icon is received in a couple more weeks at least to see if people got used to it. |
|
@ychin Thank you for a link and an information. Here I wanted to ask a technical question, not discuss my personal preferences, and you gave me a good answer. |
For anyone arriving in this thread wanting to say that they hate the new iconI hated it 24 hours ago, but now? Looks fine. Whatever. Just give it a few days. |
|
@ychin I use Here I won't discuss homebrew's merit. I'll try to get some time to investigate this (as I am not a brew wizard) |
|
Homebrew doesn't build from source by default. It builds the formulas into bottles (cached binaries) that you download from their server when you install a package, so this would only be an option if you build MacVim from source using Homebrew, and I think that's just too niche an option. |
|
@ychin this option exists in MacPorts and I'd like to see it. In home-brew it was cutoff as they have a policy to support only one configuration. PS: I have questions on MacVim to provide better support in MacPorts |
|
What would MacVim need to do to support MacPorts better? I used to use MacPorts but moved away from it, and it seems like MacPorts usually falls behind MacVim releases by a couple versions (https://ports.macports.org/port/MacVim/summary). Looking at metrics on that (which to be fair I don't know how accurate that i), it also appears the usage is quite low, which is why I'm not sure if I want to spend too much time supporting it (homebrew-core's MacVim formula is maintained by Homebrew devs and volunteers themselves). Anyway let's make a new issue if you want to add more support for MacPorts, which I'm not against. I do question if it's worth spending effort to make the icon customizable just for MacPorts though. It's a pretty niche within niche use case. |
|
I want to take maintainership of MacVim in MacPorts |
|
macvim-dev doesn't own the MacPorts definition. You may want to go to https://ports.macports.org/port/MacVim/summary and ask the maintainer instead. FWIW I don't particular support having customizable icons for the reasons I already discussed (majority of users would not be installing MacVim in a way that supports icon customization, and also I don't really think that's good for help identifying the app if we give too many icons to choose from). |
|
"it seems like MacPorts usually falls behind MacVim releases by a couple versions" maybe that explains why I just recently got the new icon... |
|
@oseiberts11 The "im" hasn't been part of the MacVim logo for a long time (at least 6 years). |
|
Interesting, you're right! I guess that the change somehow made it more "in my face" :) |
|
Also, are you using macOS 11 Big Sur @oseiberts11 ? If you are, I would be surprised if you find the old icon preferable to the new one. If you aren't, unfortunately, as has been discussed on this thread already, there isn't an easy way to support multiple icons, and as a project we should be supporting the latest macOS version as top priority while remaining backwards compatible with older versions. |
|
@ychin No, I don't (yet). Company policy has not approved it yet, I think... So this is on my work computer, that's why I notice that the icon differs so much from other Vim versions, because for my personal use I use the generic Unix version of Vim with GTK GUI. |
|
@oseiberts11 you can use your own icon locally by copying and pasting it into information window. |
Way back in #1, I submitted the currently used app icon for the then-new Yosemite version of OS X. The new icon styling for Big Sur is a pretty big departure from the current styling and it makes sense to have MacVim continue to feel current going forward (once macOS 11 ships).
This PR includes a new
MacVim.icnsthat looks like this:Option 1
I didn't include any document-specific
.icnsfiles because I read the following on this page, but I'm happy to help generate them if I'm misinterpreting.