Add support for localized message transalations in MacVim #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables localized translated messages in MacVim, instead of only using English. - Get Travis to compile MacVim with gettext dependencies which is a pre-requisite for multilang localized messages. Also add a quick regression test to make sure localized messages will keep working. - Add a post-build phase to copy all locale .mo files to VIMRUNTIME/lang so they will be bundled along with the rest in the app package. Normal Vim usually installs the localized files to a global location like /usr/local/share/locale/ but macOS applications are all self-contained bundles we don't want to do this. Use VIMRUNTIME/lang as the destination because that's also what the Windows build uses and existing code already knows to use it by using bindtextdomain. - Fix vim.h header to not unbind bindtextdomain for MacVim. There is previously a little bit of hack there where it would only use bindtextdomain when DYNAMIC_GETTEXT is set because that's only set for Windows. Just add a special case for MacVim for now to get similar behavior to Windows. Close macvim-dev#991
ychin
force-pushed
the
macvim-locale-message-translation
branch
from
6a0ac01
to
c27ef2a
Compare
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Aug 11, 2020
Since macvim-dev#1070 added support for localized messages for MacVim, add some translations for some MacVim-specific messages (only add intro text and :version output for now) for some languages (es, ja, zh) to make the intro screen look less like an odd mix.
5 tasks
11 tasks
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Nov 27, 2022
When adding support for gettext in macvim-dev#1070, a MacVim-specific ifdef was added unnecessary around `bindtextdomain`. That ifdef isn't actually necessary and it seems to have been done due to an incorrect understanding of the ifdef logic there regarding `FEAT_GETTEXT`. Just remove it to clean it up. Localization should still work.
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Jan 2, 2023
When adding support for gettext in macvim-dev#1070, a MacVim-specific ifdef was added unnecessary around `bindtextdomain`. That ifdef isn't actually necessary and it seems to have been done due to an incorrect understanding of the ifdef logic there regarding `FEAT_GETTEXT`. Just remove it to clean it up. Localization should still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables localized translated messages in MacVim, instead of only using English.
VIMRUNTIME/langso they will be bundled along with the rest in the app package. Normal Vim usually installs the localized files to a global location like /usr/local/share/locale/ but macOS applications are all self-contained bundles we don't want to do this. UseVIMRUNTIME/langas the destination because that's also what the Windows build uses and existing code already knows to use it by usingbindtextdomain.bindtextdomainfor MacVim. There is previously a little bit of hack there where it would only usebindtextdomainwhenDYNAMIC_GETTEXTis set because that's only set for Windows. Just add a special case for MacVim for now to get similar behavior to Windows.Note: This does not add translations for menus. It only adds translations for Vim messages (e.g. "Press Enter" prompts, dialog box messages, or the intro screen).
Close #991