Fix set fullscreen not working after upstream Vim merge
#1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent upstream Vim merge (v9.0.1365) contained a lot of refactoring in the option setting code. Handling option setting was now done via a standardized callback, with a struct `optset_T`. In resolving the upstream merge conflicts, `did_set_fullscreen` was erroneously using the wrong value from the union (should be using boolean instead of number) which leads to it occasionally giving unpredictable results. Fix the bug. Note that the bug seems a little unpredictable since it depends on compiler specifics. The only way it was known to trigger was by `set diff` followed by `set fullscreen`. Fix macvim-dev#1378
ychin
force-pushed
the
fix-fullscreen-option-broken-upstream-merge
branch
from
b87e695 to
0f7987a
Compare
tono
pushed a commit
to tono/macvim
that referenced
this pull request
Mar 21, 2023
…roken-upstream-merge Fix `set fullscreen` not working after upstream Vim merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent upstream Vim merge (v9.0.1365) contained a lot of refactoring in the option setting code. Handling option setting was now done via a standardized callback, with a struct
optset_T. In resolving the upstream merge conflicts,did_set_fullscreenwas erroneously using the wrong value from the union (should be using boolean instead of number) which leads to it occasionally giving unpredictable results. Fix the bug.Note that the bug seems a little unpredictable since it depends on compiler specifics. The only way it was known to trigger was by
set difffollowed byset fullscreen.Fix #1378