Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable macOS native tabs (introduced in 10.12) #788

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

ychin
Copy link
Member

@ychin ychin commented Nov 24, 2018

MacVim already has its own tabbing interface and native tabs (configurable in System Preferences) introduce a second layer of tabs which is confusing. MacVim also doesn't behave properly under such circumstances such as rendering artifacts, lacking proper native menu items (e.g. "Move Tab to New Window"), and keyboard shortcuts like Cmd-W don't work.

Note that it's currently not a good idea to implement Vim tabs using native tabs since they assume multiple NSWindow instances and assume they can be split off into multiple windows, which Vim doesn't support.

MacVim already has its own tabbing interface and native tabs
(configurable in System Preferences) introduce a second layer of tabs
which is confusing. MacVim also doesn't behave properly under such
circumstances such as rendering artifacts, lacking proper native menu
items (e.g. "Move Tab to New Window"), and keyboard shortcuts like Cmd-W
don't work.

Note that it's currently not a good idea to implement Vim tabs using
native tabs since they assume multiple NSWindow instances and assume
they can be split off into multiple windows, which Vim doesn't support.
@ychin ychin merged commit e5d1176 into macvim-dev:master Nov 24, 2018
@ychin ychin deleted the disable_native_tabs branch November 24, 2018 01:58
ychin added a commit to ychin/macvim that referenced this pull request Dec 5, 2018
Vim patch 8.1.560

Targets macOS 10.8+

Features:
- macOS Mojave (10.14) is now supported.
    - MacVim's UI now works with Dark Mode.
    - Fixed broken rendering and flickering under Mojave when using the
      default Core Text renderer. macvim-dev#757
- guioption 'k' is supported again. macvim-dev#731
    - This option prevents window from resizing when UI elements such as
      toolbars or tabs show or hide themselves.

Fixes:
- Fixed misc fullscreen and window resizing bugs and artifacts macvim-dev#745
- Dragging tabs to reorder now works properly macvim-dev#789
- Fixed timer callback handling in GUI macvim-dev#749
- Fixed native tabs (10.12+) interring with Vim tabs macvim-dev#788
- Fixed Japanese IME Ctrl-U/Ctrl-O handling macvim-dev#742
- Fixed MMShareFindPboard and Cmd-E/Cmd-G interactions macvim-dev#780
- Better handling of guifontwide font size macvim-dev#737
- Better python discovery in default vimrc macvim-dev#739

Known Issues:
- Scrolling performance is slightly worse under Mojave macvim-dev#796

Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.5
ychin added a commit that referenced this pull request Dec 5, 2018
Vim patch 8.1.560

Targets macOS 10.8+

Features:
- macOS Mojave (10.14) is now supported.
    - MacVim's UI now works with Dark Mode.
    - Fixed broken rendering and flickering under Mojave when using the
      default Core Text renderer. #757
- guioption 'k' is supported again. #731
    - This option prevents window from resizing when UI elements such as
      toolbars or tabs show or hide themselves.

Fixes:
- Fixed misc fullscreen and window resizing bugs and artifacts #745
- Dragging tabs to reorder now works properly #789
- Fixed timer callback handling in GUI #749
- Fixed native tabs (10.12+) interring with Vim tabs #788
- Fixed Japanese IME Ctrl-U/Ctrl-O handling #742
- Fixed MMShareFindPboard and Cmd-E/Cmd-G interactions #780
- Better handling of guifontwide font size #737
- Better python discovery in default vimrc #739

Known Issues:
- Scrolling performance is slightly worse under Mojave #796

Script interfaces have compatibility with these versions:
- Lua 5.3
- Perl 5.18
- Python2 2.7
- Python3 3.7
- Ruby 2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant