Fix scrollbar rendering artifact in pre-Mojave renderer #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix scrollbars not rendering properly when using delayed calls to placeScrollBars. That has issues since pre-Mojave renderer blocks the window from changing size by using `[NSAnimationContext beginGrouping]`. That causes the bug as placeScrollbars would be using state from previous sizes. We could fix this by waiting for the animation to end before called finishPlaceScrollbars but it's more complicated and leads to more state tracking. Instead, just call placeScrollbars when we resize immediately (just like before) instead of deferring. We still defer placing scrollbars for things like creating/deleting scrollbars as we could be doing that a lot of times per frame (e.g. calling `:only` with a lot of splits). Fix macvim-dev#848
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Feb 18, 2019
Vim patch 8.1.950 Fixes: - Fix Ctrl-C not working properly in Command-Line and Normal mode macvim-dev#856 - Fix scrollbar rendering artifact in macOS 10.13 or below macvim-dev#857 - matchit plugin now works again in MacVim (fixed in Vim 8.1.0875) Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
ychin
added a commit
that referenced
this pull request
Feb 18, 2019
Vim patch 8.1.950 Fixes: - Fix Ctrl-C not working properly in Command-Line and Normal mode #856 - Fix scrollbar rendering artifact in macOS 10.13 or below #857 - matchit plugin now works again in MacVim (fixed in Vim 8.1.0875) Targets macOS 10.8+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.6
ychin
added
the
UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scrollbars not rendering properly when using delayed calls to
placeScrollBars. That has issues since pre-Mojave renderer blocks the window from changing size by using[NSAnimationContext beginGrouping]. That causes the bug as placeScrollbars would be using state from previous sizes.We could fix this by waiting for the animation to end before called finishPlaceScrollbars but it's more complicated and leads to more state tracking. Instead, just call placeScrollbars when we resize immediately (just like before) instead of deferring. We still defer placing scrollbars for things like creating/deleting scrollbars as we could be doing that a lot of times per frame (e.g. calling
:onlywith a lot of splits).This bug was introduced in #827.
Fix #848