HMM fix resampling state sequence, updated documentation for developers #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKuederle
requested changes
Apr 17, 2024
gaitmap_mad/gaitmap_mad/stride_segmentation/hmm/_hmm_feature_transform.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 61 61
Lines 3283 3283
=======================================
Hits 3005 3005
Misses 278 278 ☔ View full report in Codecov by Sentry. |
|
@AKuederle |
AKuederle
approved these changes
Apr 19, 2024
AKuederle
force-pushed
the
hmm_fix_resampling
branch
from
a99ce13
to
b81d1c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AKuederle @HaMora
The resampling of the state sequence for the HMM is now fixed, tests are adapted.
Resampling is also tested for cases in which target_sample_rate is not a multiple of the Roth HMM sample rate.
Can you please review the changes?