Feature: Drilled Config #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemankv
force-pushed
the
feature/drilled-config
branch
from
aeee6be
to
4131a53
Compare
apoorvsadana
reviewed
Sep 5, 2024
apoorvsadana
reviewed
Sep 5, 2024
* update: better alert impl * ignore: empty comment to trigger CI * update: TestConfigBuilder object name changes * update: removed new_from_env() from AWSSNS * ignore: empty comment to trigger CI
Closed
heemankv
force-pushed
the
feature/drilled-config
branch
from
be7b887
to
5922815
Compare
k4kratik
pushed a commit
that referenced
this pull request
Sep 18, 2024
* update: drilled config * update: TestConfigBuilder with configurations * chore: lint fixes * chore: lint fixes #2 * update: Non-Arc Impl for TestConfigBuilder * update: New TestConfigBuilder accomodating changed on TestCases * update: uncomment fft tests * update: PR review changes #1 * update: optimised init_<service> functions * Improvement/better alert (#114) * update: better alert impl * ignore: empty comment to trigger CI * update: TestConfigBuilder object name changes * update: removed new_from_env() from AWSSNS * ignore: empty comment to trigger CI * update: starknet dummy provider optimisiation * update: starknet dummy provider + Conversion optimisiation * update: added default for ConfigType * update: mod implement_client added * update: adaptation to provider-config * fix : e2e test * update: fix integration tests * fix: PR reviews fixed * update: reworking Provider config to be an ARC --------- Co-authored-by: Arun Jangra <arunjangra1001@gmail.com>
ocdbytes
added a commit
that referenced
this pull request
Oct 16, 2024
* update: drilled config * update: TestConfigBuilder with configurations * chore: lint fixes * chore: lint fixes #2 * update: Non-Arc Impl for TestConfigBuilder * update: New TestConfigBuilder accomodating changed on TestCases * update: uncomment fft tests * update: PR review changes #1 * update: optimised init_<service> functions * Improvement/better alert (#114) * update: better alert impl * ignore: empty comment to trigger CI * update: TestConfigBuilder object name changes * update: removed new_from_env() from AWSSNS * ignore: empty comment to trigger CI * update: starknet dummy provider optimisiation * update: starknet dummy provider + Conversion optimisiation * update: added default for ConfigType * update: mod implement_client added * update: adaptation to provider-config * fix : e2e test * update: fix integration tests * fix: PR reviews fixed * update: reworking Provider config to be an ARC --------- Co-authored-by: Arun Jangra <arunjangra1001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #104 and #110.
Introduces :
parenttochildfunctions, making it more pure and removing dirty access of global config.TestConfigBuilderwith syncconfigmethod and onlybuildasync method.newforalert_clientand generalisesRegiontoAWS_REGIONremoving usage ofAWS_SNS_REGION.init_configandtestconfigbuilder.ProviderConfig- removingget_settingsand addingget_settings_or_panic.