Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: better alert impl. #111

Merged
merged 16 commits into from
Sep 5, 2024
Merged

update: better alert impl. #111

merged 16 commits into from
Sep 5, 2024

Conversation

heemankv
Copy link
Contributor

@heemankv heemankv commented Sep 5, 2024 •
edited
Loading

This PR solves #110.

  • Creates new for alert_client and generalises Region to AWS_REGION removing usage of AWS_SNS_REGION.
  • Ensures no excess access to AWS_ENV_VARS other than init_config and testconfigbuilder.

@heemankv heemankv self-assigned this Sep 5, 2024
heemankv
heemankv commented Sep 5, 2024
View reviewed changes
Copy link
Contributor Author

@heemankv heemankv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed Self Review, looks good.

@heemankv heemankv changed the base branch from feature/drilled-config to main September 5, 2024 11:37
@coveralls
Copy link

coveralls commented Sep 5, 2024 •
edited
Loading

Coverage Status

coverage: 62.675% (-1.9%) from 64.606%
when pulling 0735930 on improvement/better-alert
into f84ba41 on main.

@heemankv heemankv changed the base branch from main to feature/drilled-config September 5, 2024 12:27
apoorvsadana
apoorvsadana reviewed Sep 5, 2024
View reviewed changes
crates/orchestrator/src/alerts/aws_sns/mod.rs Outdated
}

/// To create a new SNS client from the environment variables
pub async fn new_from_env() -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this function isn't being used, let's delete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted.

@heemankv heemankv changed the base branch from feature/drilled-config to main September 5, 2024 13:32
@heemankv heemankv merged commit 21ec2cb into main Sep 5, 2024
7 checks passed
@heemankv heemankv deleted the improvement/better-alert branch September 5, 2024 13:51
@heemankv heemankv restored the improvement/better-alert branch September 5, 2024 13:51
heemankv added a commit that referenced this pull request Sep 5, 2024
@heemankv
Revert "update: better alert impl. (#111)"
74aa012 
This reverts commit 21ec2cb.
@heemankv heemankv mentioned this pull request Sep 5, 2024
Merged
heemankv added a commit that referenced this pull request Sep 5, 2024
@heemankv
Revert "update: better alert impl. (#111)" (#113)
c3f0a50 
This reverts commit 21ec2cb.
@heemankv heemankv mentioned this pull request Sep 5, 2024
Merged
ocdbytes pushed a commit that referenced this pull request Oct 16, 2024
@heemankv
update: better alert impl. (#111)
e052eac 
* update: drilled config

* update: TestConfigBuilder with configurations

* chore: lint fixes

* chore: lint fixes #2

* update: Non-Arc Impl for TestConfigBuilder

* update: New TestConfigBuilder accomodating changed on TestCases

* update: uncomment fft tests

* update: better alert impl

* update: PR review changes #1

* ignore: empty comment to trigger CI

* update: TestConfigBuilder object name changes

* update: optimised init_<service> functions

* update: removed new_from_env() from AWSSNS

* ignore: empty comment to trigger CI
ocdbytes pushed a commit that referenced this pull request Oct 16, 2024
@heemankv
Revert "update: better alert impl. (#111)" (#113)
bc9ba16 
This reverts commit 21ec2cb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana left review comments

Assignees

@heemankv heemankv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heemankv @coveralls @apoorvsadana