feat : added state update worker #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Ok(self | ||
| .get_job_collection() | ||
| .find_one(filter, find_options) |
There was a problem hiding this comment.
we should index collections
There was a problem hiding this comment.
will create the issue for this.
Comment on lines
34
to
36
| let existing_job = config | ||
| .database() | ||
| .get_job_by_internal_id_and_type(&job.internal_id, &JobType::StateTransition) |
|
|
||
| let successful_proving_jobs = config | ||
| .database() | ||
| .get_completed_jobs_after_internal_id_by_job_type( |
There was a problem hiding this comment.
let's move completed to an argument itself
| } | ||
| } | ||
|
|
||
| pub fn get_job_by_mock_id_vector( |
There was a problem hiding this comment.
let's add a comment on this
| )) | ||
| }); | ||
|
|
||
| // mocking getting of the jobs |
There was a problem hiding this comment.
let's add a comment on where this check happens
There was a problem hiding this comment.
I guess this is pending?
lcov.info
Outdated
There was a problem hiding this comment.
does this file need to be in a .gitignore?
| )) | ||
| }); | ||
|
|
||
| // mocking getting of the jobs |
There was a problem hiding this comment.
I guess this is pending?
ocdbytes
added a commit
that referenced
this pull request
Oct 16, 2024
* feat : added state update worker * feat : fixed tests and updated worker code * refactor and added some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.