Build Client inside DaConfig #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemankv
force-pushed
the
feat/build-da-client
branch
from
456cec0
to
f90dc39
Compare
| } | ||
| } | ||
|
|
||
| pub fn get_env_car_optional_or_panic(key: &str) -> Option<String> { |
There was a problem hiding this comment.
Suggested change
| pub fn get_env_car_optional_or_panic(key: &str) -> Option<String> { | |
| pub fn get_env_var_optional_or_panic(key: &str) -> Option<String> { |
heemankv
force-pushed
the
feat/build-da-client
branch
from
96ad483
to
5d729f5
Compare
apoorvsadana
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
build_clientinsideDaConfigand removes need for implementingtryfrom/fromcompletely.Problem it solves :
Not all DA clients have a
syncda client support, this PR allows creating the DA clientsasync.Important points to evaluate:
build_clienton DaConfig.ethereumDA setup inbuild_da_clientinsidecrates/orchestrator/src/config.rs.get_env_var_optional: optional env support, ifenvvariable is not found,Noneis passed.