Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping images broken #422

Open
timmyg opened this issue Dec 22, 2015 · 3 comments
Open

Dropping images broken #422

timmyg opened this issue Dec 22, 2015 · 3 comments

Comments

@timmyg
Copy link

timmyg commented Dec 22, 2015

Getting below when trying to drop images in demo of master branch.

Uncaught SyntaxError: Failed to execute 'querySelector' on 'Document': '#' is not a valid selector.onDrop @ block-reorder.js:56
@raffij
Copy link
Contributor

raffij commented Dec 24, 2015

@timmyg looked into this and pretty sure it's only occurring when you are dropping on the white area rather than the grey middle.

Working on a better interface which will be pr'd shortly. This will make dragging to the inner area feel more intuitive and focused styled to show that.

@raffij raffij added the Bug label Feb 4, 2016
@zyuhel
Copy link

zyuhel commented May 11, 2016

May be dropping images on white section need to create new image block type there? it will be a great usability bonus imo. It need time to understand that you can't just drop image, you need first create image block and drop on it. If user is dropping an image between blocks then it is obvious that he want to add it. Why forcing him to create image block by himself.

@raffij
Copy link
Contributor

raffij commented May 12, 2016

@zyuhel this has about from the change of the look of the editor from a purely block based view to more of a document view. Need to get back to the changes I was making for tim.

Thanks for the feedback, i'll take it into account when improving drag and drop in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants