Prevent form submission untill files finished uploading

[SgtOddball]

I've come across abit of an interesting unintended consequence of the images block (well the images_extended block, but the issues the same for both).

You can cause issues with your back end (phnar, phnar) by submitting the Sir trev data before an image has finished uploading and the block has received the uid, url and newFile name.

Would it be possible to block submission until uploads have completed? (In the same way that required blocks behave?).

This is more of a usability issue than an outright bug but I'd be interested to see what the general consensus is.

[andflett]

Not sure what version you're on, but agree, prehistoric versions used to
just disable the form (and show a "please wait, uploading" notice or
something similar near the save button) until complete (or failed)
On Thu, 16 Jun 2016 at 09:22, Chris Monkman notifications@github.com
wrote:

I've come across abit of an interesting unintended consequence of the
images block (well the images_extended block, but the issues the same for
both).

You can cause issues with your back end (phnar, phnar) by submitting the
Sir trev data before an image has finished uploading and the block has
received the uid, url and newFile name.

Would it be possible to block submission until uploads have completed? (In
the same way that required blocks behave?).

This is more of a usability issue than an outright bug but I'd be
interested to see what the general consensus is.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#477, or mute the
thread
https://github.com/notifications/unsubscribe/AAlzblvUBrZCJDe3GinqHpAlQQEGafHuks5qMQfdgaJpZM4I3I1g
.

[SgtOddball]

Still running v0.5.0, I know I need to move onto v0.6.0 at some point but i've been using the columns block and as of yet it's not been moved over (and I haven't had the time to sit down and look at what would need to be done to pass over the changes between Sir trev and the Mr Trev project that's required for said column block, lazy of me I know but I haven't had the time to go over it).

I do see the uploading spinner but there's no sign of 'please wait' just a warning if it fails to upload correctly.

[raffij]

@SgtOddball oh that should all 'just work'. Famous last words. Likely the button isn't being matched with some javascript, or Mr Trevor is from before it was implemented correctly.

[SgtOddball]

Ahh, I think it might be that it's not hitting the javascript catch all then. In fairness I have tweaked the hell out of the image block so it might be to do with that.

I'll have a check on the latest version of Sir Trev in the near future and see if it's still the case, then add the custom blocks and see what happens.