Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block creation causes the page to be scrolled to the wrong offset. #237

Closed
wants to merge 1 commit into from

Conversation

raffij
Copy link
Contributor

@raffij raffij commented Aug 29, 2014

On a long page where the editor is not the first element using position().top means the html.body is scrolled too far up the page.

Should this be offset rather than position?

@dwb
Copy link
Contributor

dwb commented Dec 3, 2014

Opinions from @ninjabiscuit @cjbell? Very easy to port if it's good!

@ninjabiscuit
Copy link
Contributor

I would like to kill the scrolling altogether. It's very annoying. Unless
@cjbell or anyone else has any strong feelings?

On Wednesday, December 3, 2014, Dan Brown notifications@github.com wrote:

Opinions from @ninjabiscuit https://github.com/ninjabiscuit @cjbell
https://github.com/cjbell? Very easy to port if it's good!


Reply to this email directly or view it on GitHub
#237 (comment)
.

@raffij
Copy link
Contributor Author

raffij commented Dec 5, 2014

@ninjabiscuit i'm all for removing it.

@olvado
Copy link
Member

olvado commented Dec 5, 2014

+1 here

Oli Matthews
http://madebymany.com | @olvado
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Friday, 5 December 2014 at 09:50, Raffi Jacobs wrote:

@ninjabiscuit (https://github.com/ninjabiscuit) i'm all for removing it.


Reply to this email directly or view it on GitHub (#237 (comment)).

@cjbell
Copy link
Contributor

cjbell commented Dec 5, 2014

+1 to remove

raffij pushed a commit that referenced this pull request Mar 1, 2016
Added missing shebang statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants