Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of objects with multiple equal keys. #11

Closed
madeso opened this issue May 28, 2019 · 2 comments
Closed

Better handling of objects with multiple equal keys. #11

madeso opened this issue May 28, 2019 · 2 comments
Labels
enhancement New feature or request macro

Comments

@madeso
Copy link
Owner

madeso commented May 28, 2019

The current implementation of the object uses a std::map for storing the key/values but according to ecma 404 there can be many entries with the same key.

There should be at least 3 options:

  • All but the last key is ignored (current behavior)
  • Multiple equal keys are an error
  • All keys are stored in a multimap.
@madeso madeso added enhancement New feature or request really important labels May 28, 2019
madeso added a commit that referenced this issue Jun 2, 2019
@madeso
Copy link
Owner Author

madeso commented Jun 2, 2019

Given commit d99754a the 2 top functions are now possible, the only thing that remain is the ability to store keys in a multimap.

@madeso
Copy link
Owner Author

madeso commented Jul 3, 2020

Reading multikeys are not important, in the new "opinionated json parser", and ignored and error are already supported, so I'm closing this issue since it's complete.

@madeso madeso closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request macro
Projects
None yet
Development

No branches or pull requests

1 participant