-
Notifications
You must be signed in to change notification settings - Fork 8
updating to latest versions of deps which require a go version update #38
Conversation
WalkthroughThe recent changes involve updating the Go version for downloading and installing Go binaries in workflows for benchmarks and tests. The sleep time before executing benchmarks was reduced from 120 seconds to 60 seconds, and a Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 8 8
Lines 779 779
=======================================
Hits 701 701
Misses 54 54
Partials 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.mod
is excluded by:!**/*.mod
go.sum
is excluded by:!**/*.sum
Files selected for processing (3)
- drivers/mock/mock_test.go (1 hunks)
- drivers/redis/redis.go (1 hunks)
- drivers/redis/redis_test.go (1 hunks)
Additional comments: 3
drivers/redis/redis_test.go (1)
- 37-37: The modification to remove the explicit parameter name
t
in the "Fake TLS" test case function is a good practice for unused parameters, enhancing code readability without impacting functionality.drivers/mock/mock_test.go (1)
- 82-82: Changing the
SetFunc
parameter to an unnamed variable_ []byte
is a good practice for unused parameters, improving code clarity and maintainability.drivers/redis/redis.go (1)
- 208-208: The modification to ignore the
time.Time
parameter in theTestOnBorrow
function signature warrants further verification to ensure it does not negatively impact the connection pool's health check mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
go.mod
is excluded by:!**/*.mod
Files selected for processing (2)
- .github/workflows/benchmarks.yml (6 hunks)
- .github/workflows/tests.yml (7 hunks)
Additional comments: 14
.github/workflows/benchmarks.yml (7)
- 44-44: The Go version has been updated to
1.22.0
. This change aligns with the PR's objective to update dependencies and the Go version to stay compatible with the latest NATS release. Ensure that all Go code in the project is compatible with Go1.22.0
.- 68-68: The Go version has been updated to
1.22.0
for the Redis job. This is consistent with the updates in other jobs and supports the PR's objective.- 68-68: The sleep time before executing Redis benchmarks has been reduced from 120 seconds to 60 seconds. This change could potentially speed up the workflow execution time. However, ensure that this reduced sleep time does not affect the stability of the benchmarks, especially in environments where services might take longer to become fully operational.
- 85-85: The Go version has been updated to
1.22.0
for the KeyDB job. This consistency across jobs is good for maintaining the project's compatibility with the latest Go version.- 107-107: Updating the Go version to
1.22.0
for the NATS job aligns with the PR's objectives. This consistency in Go version updates across the workflow is commendable.- 121-121: The Go version update to
1.22.0
for the Hashmap job is approved. This change is part of the broader effort to keep the project up-to-date with the latest Go version.- 133-133: The Go version has been updated to
1.22.0
for the BoltDB job. This update is consistent with the changes in other jobs and supports the overall objective of the PR..github/workflows/tests.yml (7)
- 21-21: The Go version has been updated to
1.22.0
for the Hord job. This update is necessary to stay compatible with the latest NATS release and other updated dependencies.- 60-60: The Go version has been updated to
1.22.0
for the Cassandra job. Additionally, asleep 120
command has been added before executing tests. This change aligns with the PR's objectives. Ensure that the added sleep time is necessary and does not unduly delay the workflow execution.- 98-98: The Go version has been updated to
1.22.0
for the Redis job. This update is consistent with the changes in other jobs and supports the PR's objective to stay up-to-date with the latest Go version.- 125-125: Updating the Go version to
1.22.0
for the NATS job aligns with the PR's objectives. This consistency in Go version updates across the workflow is commendable.- 140-140: The Go version update to
1.22.0
for the Mock job is approved. This change is part of the broader effort to keep the project up-to-date with the latest Go version.- 154-154: The Go version has been updated to
1.22.0
for the Hashmap job. This update is consistent with the changes in other jobs and supports the overall objective of the PR.- 168-168: The Go version has been updated to
1.22.0
for the BoltDB job. This update is consistent with the changes in other jobs and supports the overall objective of the PR.
Newest NATS version requires a go version update.
Summary by CodeRabbit
1.22.0
.sleep 120
command before executing tests in a specific job.