Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

updating to latest versions of deps which require a go version update #38

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

madflojo
Copy link
Owner

@madflojo madflojo commented Mar 2, 2024

Newest NATS version requires a go version update.

Summary by CodeRabbit

  • Refactor
    • Improved code efficiency in test functions by optimizing unused variables and parameters.
    • Enhanced the Redis driver by adjusting function signatures for better performance and readability.
  • Chores
    • Updated Go versions in workflow files for benchmarks and tests to 1.22.0.
    • Adjusted sleep time before executing benchmarks from 120 seconds to 60 seconds.
    • Added a sleep 120 command before executing tests in a specific job.

Copy link
Contributor

coderabbitai bot commented Mar 2, 2024

Walkthrough

The recent changes involve updating the Go version for downloading and installing Go binaries in workflows for benchmarks and tests. The sleep time before executing benchmarks was reduced from 120 seconds to 60 seconds, and a sleep 120 command was added before running tests in one of the jobs.

Changes

Files Change Summary
.github/workflows/benchmarks.yml, .github/workflows/tests.yml Updated Go version from 1.19.9 to 1.22.0 for downloading and installing binaries. Adjusted sleep time before benchmarks and added a sleep 120 command before running tests in one job.

Poem

🐰✨
In the land of workflows, where changes play their part,
We upgraded versions with a skip in our heart.
Benchmarks and tests, now run with new might,
Time reduced, code shining bright.
With each tweak and adjustment we make,
Our digital journey, a cleaner code lake.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (d4fb1e0) to head (b3dec76).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files           8        8           
  Lines         779      779           
=======================================
  Hits          701      701           
  Misses         54       54           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d4fb1e0 and e576f75.
Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
Files selected for processing (3)
  • drivers/mock/mock_test.go (1 hunks)
  • drivers/redis/redis.go (1 hunks)
  • drivers/redis/redis_test.go (1 hunks)
Additional comments: 3
drivers/redis/redis_test.go (1)
  • 37-37: The modification to remove the explicit parameter name t in the "Fake TLS" test case function is a good practice for unused parameters, enhancing code readability without impacting functionality.
drivers/mock/mock_test.go (1)
  • 82-82: Changing the SetFunc parameter to an unnamed variable _ []byte is a good practice for unused parameters, improving code clarity and maintainability.
drivers/redis/redis.go (1)
  • 208-208: The modification to ignore the time.Time parameter in the TestOnBorrow function signature warrants further verification to ensure it does not negatively impact the connection pool's health check mechanism.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e576f75 and b3dec76.
Files ignored due to path filters (1)
  • go.mod is excluded by: !**/*.mod
Files selected for processing (2)
  • .github/workflows/benchmarks.yml (6 hunks)
  • .github/workflows/tests.yml (7 hunks)
Additional comments: 14
.github/workflows/benchmarks.yml (7)
  • 44-44: The Go version has been updated to 1.22.0. This change aligns with the PR's objective to update dependencies and the Go version to stay compatible with the latest NATS release. Ensure that all Go code in the project is compatible with Go 1.22.0.
  • 68-68: The Go version has been updated to 1.22.0 for the Redis job. This is consistent with the updates in other jobs and supports the PR's objective.
  • 68-68: The sleep time before executing Redis benchmarks has been reduced from 120 seconds to 60 seconds. This change could potentially speed up the workflow execution time. However, ensure that this reduced sleep time does not affect the stability of the benchmarks, especially in environments where services might take longer to become fully operational.
  • 85-85: The Go version has been updated to 1.22.0 for the KeyDB job. This consistency across jobs is good for maintaining the project's compatibility with the latest Go version.
  • 107-107: Updating the Go version to 1.22.0 for the NATS job aligns with the PR's objectives. This consistency in Go version updates across the workflow is commendable.
  • 121-121: The Go version update to 1.22.0 for the Hashmap job is approved. This change is part of the broader effort to keep the project up-to-date with the latest Go version.
  • 133-133: The Go version has been updated to 1.22.0 for the BoltDB job. This update is consistent with the changes in other jobs and supports the overall objective of the PR.
.github/workflows/tests.yml (7)
  • 21-21: The Go version has been updated to 1.22.0 for the Hord job. This update is necessary to stay compatible with the latest NATS release and other updated dependencies.
  • 60-60: The Go version has been updated to 1.22.0 for the Cassandra job. Additionally, a sleep 120 command has been added before executing tests. This change aligns with the PR's objectives. Ensure that the added sleep time is necessary and does not unduly delay the workflow execution.
  • 98-98: The Go version has been updated to 1.22.0 for the Redis job. This update is consistent with the changes in other jobs and supports the PR's objective to stay up-to-date with the latest Go version.
  • 125-125: Updating the Go version to 1.22.0 for the NATS job aligns with the PR's objectives. This consistency in Go version updates across the workflow is commendable.
  • 140-140: The Go version update to 1.22.0 for the Mock job is approved. This change is part of the broader effort to keep the project up-to-date with the latest Go version.
  • 154-154: The Go version has been updated to 1.22.0 for the Hashmap job. This update is consistent with the changes in other jobs and supports the overall objective of the PR.
  • 168-168: The Go version has been updated to 1.22.0 for the BoltDB job. This update is consistent with the changes in other jobs and supports the overall objective of the PR.

@madflojo madflojo merged commit aaba081 into main Mar 2, 2024
16 checks passed
@madflojo madflojo deleted the versionupdate branch March 2, 2024 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant