-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding methods for exporting #16
Conversation
WalkthroughThe pull request introduces two new Changes
Sequence DiagramsequenceDiagram
participant CA as CertificateAuthority
participant KP as KeyPair
CA->>CA: Cert()
CA-->>User: Returns X.509 Certificate
KP->>KP: Cert()
KP-->>User: Returns X.509 Certificate
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
testcerts.go
(2 hunks)testcerts_test.go
(2 hunks)
🧰 Additional context used
🪛 golangci-lint (1.62.2)
testcerts_test.go
29-29: SA5011: possible nil pointer dereference
(staticcheck)
26-26: SA5011(related information): this check suggests that the pointer can be nil
(staticcheck)
🔇 Additional comments (2)
testcerts.go (2)
197-201
: Looks Good!
This new Cert()
method on CertificateAuthority
is succinct and properly returns ca.cert
. The structure is straightforward, and the new public method is well-aligned with the PR objectives of enabling direct certificate retrieval.
279-283
: Straightforward Implementation
Similarly, this Cert()
method on KeyPair
mirrors the newly added Cert()
method on CertificateAuthority
. The direct return of kp.cert
is consistent and meets the PR objectives.
0dab7ca
to
f028056
Compare
Adds a method to KeyPair and CertificateAuthority to export the certificate to an struct directly.
f028056
to
b49928d
Compare
@mys721tx looks great thanks for the contribution! |
Adds a method to KeyPair and CertificateAuthority to export the certificate to an struct directly.
Summary by CodeRabbit
New Features
CertificateAuthority
andKeyPair
.Bug Fixes