Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #157

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Update README.md #157

merged 1 commit into from
Mar 17, 2024

Conversation

TeslaOwnerTips
Copy link
Contributor

Small format error that lead to incorrect url

Small format error that lead to incorrect url
@TeslaOwnerTips
Copy link
Contributor Author

When viewed on my iPhone web browser

@madiele
Copy link
Owner

madiele commented Mar 17, 2024

Will merge this later.

On another not I've missed this snippet in the original PR

Mac: Make sure Rust is installed https://www.rust-lang.org

which is in the docker section, that should not be required if using docker compose installation method, that makes sense only if installing vod2pod-rss natively on the machine, I would move that to the contributing.md where instruction about native installation are (I prefer the goto installation to be docker only to reduce misconfiguration errors)

@TeslaOwnerTips
Copy link
Contributor Author

I agree about Rust. But I followed your instructions and it failed with Rust not found. Since I don’t use docker I assumed it was needed. So I installed it and went back to following your instructions.

My Google located this post so without investing further I just installed Rust and went back to the instructions

acheong08/ChatGPT#572

@madiele
Copy link
Owner

madiele commented Mar 17, 2024

Yeah docker can be summed up as a virtual machine (not really but it's close enough), it will install rust inside the virtual machine so no need to install it yourself.

Docker-compose needing rust to run sounds very weird to me, unfortunately I don't have an m1 mac so I can't make sure of it but it should work with no problem since I do support arm64 builds (I actually use them on my raspberry pi)

Did you get vod2pod-rss to run inside docker or natively on your Mac? The latter would explain why you got the error

@madiele madiele merged commit fea1770 into madiele:main Mar 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants